Don't fail if NETWORK_POLICY_PROVIDER is unset #28256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
k8s-github-robot
added
size/XS
|
GCE e2e build/test passed for commit 7d669ec. |
| if [[ -n ${appends} ]]; then | ||
| if [[ -n ${RUNTIME_CONFIG} ]]; then | ||
| if [[ -n ${appends:-} ]]; then | ||
| if [[ -n ${RUNTIME_CONFIG:-} ]]; then |
There was a problem hiding this comment.
pedanticly, this should be quote-wrapped.
|
@thockin - As per the conversation here: #28401 (comment) should we just always enable this and get rid of all the if/then logic? |
|
yes, I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue from this comment: https://github.com/kubernetes/kubernetes/pull/26017/files/35289c764954011e69d289a20ccb26fd3b0f1062#r68873333
@ixdy Haven't had a chance to test this against AWS, but I think it fixes your issue.