New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return of empty list in kubectl get #28251

Closed

metral wants to merge 1 commit into kubernetes:master from metral:fix-get-output

Contributor

metral commented Jun 29, 2016 •

edited

Loading

fixes #28243

When printing the obj in a generic kubectl get (where the obj is a versioned object of infos), it should only be printing valid objects from infos. In the case of the referred issue, if infos is nil, then it will print out the empty object along with the error, rather than just the error.

This PR ensures that the printing of objects only occurs if infos is not empty.

Is it viable to try to squeeze this into v1.3 given that it hasn't been cut yet and this is an outward-facing bug?


          fix return of empty list in kubectl get

007fe03

googlebot added the cla: yes label

k8s-bot commented Jun 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

4 similar comments

k8s-bot commented Jun 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jun 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jun 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jun 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-github-robot assigned smarterclayton

k8s-github-robot added size/S release-note-label-needed labels

metral mentioned this pull request

kubectl: don't display an empty list when trying to get a single resource that isn't found #28294

Merged

Contributor Author

metral commented Jun 30, 2016

There is similar fix for this issue in PR #28294

I'll defer to @smarterclayton @janetkuo to advise

metral mentioned this pull request

kubectl get displays an empty list + returns an error when trying to get a nonexistent resource #28243

Closed

metral closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S