Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert revert of #28172 #28233

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Revert revert of #28172 #28233

merged 1 commit into from
Jun 29, 2016

Conversation

zmerlynn
Copy link
Member

We're going to try reintroducing just the build changes in #28172, get signal off of that, and wait on re-introducing #28193. I also setup the gke-updown job for faster signal: kubernetes/test-infra#239.

This reverts commit fe64293.

Analytics

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 29, 2016
@zmerlynn zmerlynn added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 29, 2016
@zmerlynn zmerlynn modified the milestones: rktnetes-v1.1, next-candidate, v1.3 Jun 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit ae313b6.

@zmerlynn zmerlynn added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. retest-not-required and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 29, 2016
@j3ffml j3ffml added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 29, 2016
@zmerlynn zmerlynn added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 29, 2016
@zmerlynn
Copy link
Member Author

I figured out what's going on. See kubernetes/test-infra#240 (comment) . Real fix incoming.

@zmerlynn zmerlynn removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 29, 2016
@zmerlynn
Copy link
Member Author

I can fix this in test-infra alone, I'm fairly sure.

@zmerlynn zmerlynn mentioned this pull request Jun 29, 2016
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3d22132 into kubernetes:master Jun 29, 2016
@zmerlynn zmerlynn deleted the revert-revert-28172 branch June 29, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j3ffml j3ffml

@ixdy ixdy

Labels
area/build-release lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@zmerlynn @k8s-bot @k8s-github-robot @j3ffml @googlebot @ixdy