[Kubelet] Add support for pod level cgroup management #28017

dubstack · 2016-06-24T13:10:56Z

This PR is tied to this upstream issue #27204

This PR adds support for creating destroying and updating pod level cgroups in the Kubelet. I need the node info(Allocatable and Capacity values tp be specific) for updating the limits on the pod and top level cgroups. I pass the nodeInfo from the Kubelet to the containerManager's Start() method and then cache it in the ContainerManager. This is not the very best way to handle this requirement. But cm object is created in app/server.go where I believe we don't have the Node info at that point. cc @derekwaynecarr.

I would injecting calls to podContainerManager create and delete methods in the next PR. Also the containers would be brought up under the pod level cgroups. So I would like to get these merged only after this code has been well tested in the next PR.

@vishh @derekwaynecarr @Random-Liu Please do a review.

cc @kubernetes/sig-node

This change is

dubstack · 2016-06-24T13:34:27Z

pkg/kubelet/cm/pod_container_manager.go

+}
+
+func (m *podContainerManagerStub) GetPodContainerName(pod *api.Pod) string {
+	return ""


I missed this but it would return the cgroup-root in this case

dubstack · 2016-06-28T22:10:09Z

pkg/kubelet/cm/container_manager_linux.go

+		},
+	}
+}
+
 // TODO(vmarmol): Add limits to the system containers.


Later when we handle system containers we would want to replace this manager with my cgroup Manager

k8s-github-robot · 2016-07-28T17:35:41Z

@dubstack
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

dubstack · 2016-07-28T17:41:50Z

k8s-bot e2e test this issue: #29559

dubstack · 2016-07-28T17:49:38Z

k8s-bot test this issue: #29559

derekwaynecarr · 2016-07-28T19:24:31Z

@dubstack - I am ok addressing nits in a follow-on, can you get tests passing so I can tag?

dubstack · 2016-07-28T20:43:59Z

Looks like #29492 reverted changes that I made to Libcontainer which broke down the e2e tests

vishh · 2016-08-03T22:57:10Z

pkg/kubelet/cm/container_manager.go

+	NewPodContainerManager() PodContainerManager
+
+	// GetMountedSubsystems returns the mounted cgroup subsytems on the node
+	GetMountedSubsystems() *CgroupSubsystems


Why is this method exported?

Its being used here: https://github.com/kubernetes/kubernetes/pull/29049/files#diff-bf28da68f62a8df6e99e447c4351122dR1516

it feels like the factoring could be better here. it feels like reducing memory limits should be handled in a module opaque to the kubelet.

vishh · 2016-08-03T23:18:25Z

@dubstack DId a review pass. Please ping once you have addressed comments.

derekwaynecarr · 2016-08-04T22:00:37Z

took one more pass, i would prefer if its not too much work that we fix to use a NodeCapacityProvider interface now so we are not chasing down uses of *Node in future.

dubstack · 2016-08-04T22:12:48Z

@derekwaynecarr @vishh I understand your concern. I will send out a patch to refactor it to use a NodeCapacityInterface. But for now can we get this in.

dubstack · 2016-08-04T22:39:33Z

This commit would be added by #29087. Close this one on LGTM.

k8s-bot · 2016-08-04T23:00:57Z

GCE e2e build/test passed for commit b1018be.

dubstack · 2016-08-20T00:04:42Z

@derekwaynecarr @vishh Closing this PR as the commit from this PR will go in #30475.

googlebot · 2016-08-20T00:04:45Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@vishh

Automatic merge from submit-queue Unblock iterative development on pod-level cgroups In order to allow forward progress on this feature, it takes the commits from #28017 #29049 and then it globally disables the flag that allows these features to be exercised in the kubelet. The flag can be re-added to the kubelet when its actually ready. /cc @vishh @dubstack @kubernetes/rh-cluster-infra

@vishh

Automatic merge from submit-queue Unblock iterative development on pod-level cgroups In order to allow forward progress on this feature, it takes the commits from kubernetes#28017 kubernetes#29049 and then it globally disables the flag that allows these features to be exercised in the kubelet. The flag can be re-added to the kubelet when its actually ready. /cc @vishh @dubstack @kubernetes/rh-cluster-infra

googlebot added the cla: yes label Jun 24, 2016

dubstack added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 24, 2016

dubstack assigned dubstack and vishh and unassigned dubstack Jun 24, 2016

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Jun 24, 2016

dubstack added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 24, 2016

dubstack reviewed Jun 24, 2016
View reviewed changes

dubstack force-pushed the dubstack-pod-manager branch 4 times, most recently from 020f678 to d2e1d72 Compare June 27, 2016 09:14

dubstack removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 27, 2016

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2016

dubstack force-pushed the dubstack-pod-manager branch 2 times, most recently from f6a02d2 to 617d427 Compare June 28, 2016 21:54

dubstack changed the title ~~[Do not Merge]Add support for pod level cgroup management~~ [Kubelet] Add support for pod level cgroup management Jun 28, 2016

dubstack added area/kubelet and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 28, 2016

k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 28, 2016

dubstack reviewed Jun 28, 2016
View reviewed changes

dubstack added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 28, 2016

dubstack force-pushed the dubstack-pod-manager branch 3 times, most recently from 8d6aaf4 to f9086f1 Compare June 29, 2016 20:35

k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016

dubstack force-pushed the dubstack-pod-manager branch from c2355d2 to a01c8cd Compare July 28, 2016 18:04

dubstack removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 28, 2016

derekwaynecarr mentioned this pull request Aug 2, 2016

Update the Pod Resource Management Proposal with Implementation status #29583

Merged

vishh reviewed Aug 3, 2016
View reviewed changes

dubstack force-pushed the dubstack-pod-manager branch from a01c8cd to 1eebf62 Compare August 4, 2016 22:08

Add support for pod container management

b1018be

dubstack force-pushed the dubstack-pod-manager branch from 1eebf62 to b1018be Compare August 4, 2016 22:18

dubstack mentioned this pull request Aug 4, 2016

[kubelet] Add pod cgroups support #29087

Closed

derekwaynecarr mentioned this pull request Aug 11, 2016

Unblock iterative development on pod-level cgroups #30475

Merged

googlebot added cla: no and removed cla: yes labels Aug 20, 2016

dubstack closed this Aug 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Kubelet] Add support for pod level cgroup management #28017

[Kubelet] Add support for pod level cgroup management #28017

dubstack commented Jun 24, 2016 •

edited by k8s-oncall

Loading

dubstack Jun 24, 2016

dubstack Jun 28, 2016

k8s-github-robot commented Jul 28, 2016

dubstack commented Jul 28, 2016 •

edited

Loading

dubstack commented Jul 28, 2016

derekwaynecarr commented Jul 28, 2016

dubstack commented Jul 28, 2016

vishh Aug 3, 2016

dubstack Aug 4, 2016

derekwaynecarr Aug 4, 2016

dubstack Aug 4, 2016

vishh commented Aug 3, 2016

derekwaynecarr commented Aug 4, 2016

dubstack commented Aug 4, 2016

dubstack commented Aug 4, 2016

k8s-bot commented Aug 4, 2016

dubstack commented Aug 20, 2016

googlebot commented Aug 20, 2016

[Kubelet] Add support for pod level cgroup management #28017

[Kubelet] Add support for pod level cgroup management #28017

Conversation

dubstack commented Jun 24, 2016 • edited by k8s-oncall Loading

dubstack Jun 24, 2016

Choose a reason for hiding this comment

dubstack Jun 28, 2016

Choose a reason for hiding this comment

k8s-github-robot commented Jul 28, 2016

dubstack commented Jul 28, 2016 • edited Loading

dubstack commented Jul 28, 2016

derekwaynecarr commented Jul 28, 2016

dubstack commented Jul 28, 2016

vishh Aug 3, 2016

Choose a reason for hiding this comment

dubstack Aug 4, 2016

Choose a reason for hiding this comment

derekwaynecarr Aug 4, 2016

Choose a reason for hiding this comment

dubstack Aug 4, 2016

Choose a reason for hiding this comment

vishh commented Aug 3, 2016

derekwaynecarr commented Aug 4, 2016

dubstack commented Aug 4, 2016

dubstack commented Aug 4, 2016

k8s-bot commented Aug 4, 2016

dubstack commented Aug 20, 2016

googlebot commented Aug 20, 2016

dubstack commented Jun 24, 2016 •

edited by k8s-oncall

Loading

dubstack commented Jul 28, 2016 •

edited

Loading