Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #27829 #27866

Closed
wants to merge 2 commits into from
Closed

Automated cherry pick of #27829 #27866

wants to merge 2 commits into from

Conversation

zmerlynn
Copy link
Member

Cherry pick of #27829 on release-1.3.

zmerlynn added 2 commits June 22, 2016 06:02
@zmerlynn
Revert "GCE: Allow nodes to exceed target pool maximums"
15b6173 
This reverts commit faf0c44.
@zmerlynn
GCE provider: Create TargetPool with 200 instances, then update with …
db82f73 
…rest

Tested with 2000 nodes, this actually meets the GCE API specifications
(which is nutty). Previous PR (kubernetes#25178) was based on a mistaken
understanding of a poorly documented set of limitations, and even
poorer testing, for which I am embarassed.
@zmerlynn zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 22, 2016
@zmerlynn
Copy link
Member Author

If #27865 makes it into release-1.2, this should go into release-1.3.

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 22, 2016

GCE e2e build/test passed for commit db82f73.

@zmerlynn zmerlynn added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2016
@k8s-github-robot k8s-github-robot added this to the v1.3 milestone Jun 22, 2016
@zmerlynn
Copy link
Member Author

Bulk cherrypicks for 1.3, closing.

@zmerlynn zmerlynn closed this Jun 22, 2016
@eparis eparis removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@zmerlynn @k8s-bot @googlebot @roberthbailey @eparis @k8s-github-robot