Kubelet Volume Manager Wait For Attach Detach Controller and Backoff on Error #27567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saad-ali
added
the
release-note-none
k8s-github-robot
added
kind/api-change
|
How is this coming? |
Should have the PR ready to review today. Code review will likely take at least til Monday. |
saad-ali
force-pushed
the
blockKubeletOnAttachController
branch
4 times, most recently
from
6338ccb to
53ee9b0
Compare
k8s-github-robot
added
size/XXL
saad-ali
force-pushed
the
blockKubeletOnAttachController
branch
from
40f4dcd to
4507256
Compare
saad-ali
added
the
priority/important-soon
saad-ali
changed the title
saad-ali
force-pushed
the
blockKubeletOnAttachController
branch
from
4507256 to
046db52
Compare
|
@caesarxuchao Could you please review the "Add patch status to Node internalclientset" commit. |
|
|
||
| // PatchStatus modifies the status of an existing node. It returns the copy of | ||
| // the node that the server returns, or an error. | ||
| func (c *nodes) PatchStatus(nodeName string, data []byte) (*api.Node, error) { |
There was a problem hiding this comment.
FYI, #27293 is adding a Patch method to all clients, but it's not 1.3, and doesn't support subresource yet.
There was a problem hiding this comment.
The code LGTM for 1.3. I'll refactor it when #27293 is merged.
There was a problem hiding this comment.
Great, thanks @caesarxuchao!
| existingOp.operationPending = false | ||
|
|
||
| grm.operations[operationName] = existingOp | ||
| if *err != nil { |
There was a problem hiding this comment.
err must be not nil here already, we can remove if
Modify attach/detach controller to keep track of volumes to report attached in Node VolumeToAttach status. Modify kubelet volume manager to wait for volume to show up in Node VolumeToAttach status. Implement exponential backoff for errors in volume manager and attach detach controller
|
Thanks @jingxu97! Feedback addressed, PTAL |
saad-ali
force-pushed
the
blockKubeletOnAttachController
branch
from
046db52 to
e716ddc
Compare
|
GCE e2e build/test passed for commit e716ddc. |
|
LGTM |
jingxu97
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e716ddc. |
|
Automatic merge from submit-queue |
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
…hController Automatic merge from submit-queue Kubelet Volume Manager Wait For Attach Detach Controller and Backoff on Error * Closes kubernetes#27483 * Modified Attach/Detach controller to report `Node.Status.AttachedVolumes` on successful attach (unique volume name along with device path). * Modified Kubelet Volume Manager wait for Attach/Detach controller to report success before proceeding with attach. * Closes kubernetes#27492 * Implemented an exponential backoff mechanism for for volume manager and attach/detach controller to prevent operations (attach/detach/mount/unmount/wait for controller attach/etc) from executing back to back unchecked. * Closes kubernetes#26679 * Modified volume `Attacher.WaitForAttach()` methods to uses the device path reported by the Attach/Detach controller in `Node.Status.AttachedVolumes` instead of calling out to cloud providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.Status.AttachedVolumeson successful attach (unique volume name along with device path).Attacher.WaitForAttach()methods to uses the device path reported by the Attach/Detach controller inNode.Status.AttachedVolumesinstead of calling out to cloud providers.