Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #26418 #27113

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Automated cherry pick of #26418 #27113

merged 1 commit into from
Jun 21, 2016

Conversation

adohe-zz
Copy link

@adohe-zz adohe-zz commented Jun 9, 2016 •
edited
Loading

Cherry pick of #26418 on release-1.2. @bgrant0607 ptal.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 9, 2016
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 9, 2016
@bgrant0607
Copy link
Member

Thanks. LGTM.

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 10, 2016
@bgrant0607 bgrant0607 added this to the v1.2 milestone Jun 10, 2016
@bgrant0607 bgrant0607 assigned janetkuo and unassigned bgrant0607 Jun 14, 2016
@bgrant0607
Copy link
Member

@janetkuo Please help shepherd this cherrypick.

The e2e failure was:

• Failure [115.429 seconds]
Kubectl client
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:1200
  Kubectl rolling-update
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:1030
    should support rolling-update to same image [Conformance] [It]
    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:1029

    Expected error:
        <*errors.errorString | 0xc2083a0900>: {
            s: "Error running &{/var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/kubernetes/platforms/linux/amd64/kubectl [kubectl --server=https://104.154.107.48 --kubeconfig=/var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/.kube/config rolling-update e2e-test-nginx-rc --update-period=1s --image=gcr.io/google_containers/nginx:1.7.9 --image-pull-policy=IfNotPresent --namespace=e2e-tests-kubectl-uyuh7] []  <nil> Error updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 3 secondsError updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 9 secondsError updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 81 seconds Error from server: pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again\n [] <nil> 0xc208561300 exit status 1 <nil> true [0xc2083b6460 0xc2083b6480 0xc2083b64a0] [0xc2083b6460 0xc2083b6480 0xc2083b64a0] [0xc2083b6478 0xc2083b6498] [0x968650 0x968650] 0xc208393a40}:\nCommand stdout:\nError updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 3 secondsError updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 9 secondsError updating pod (pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 81 seconds\nstderr:\nError from server: pods \"e2e-test-nginx-rc-9s4g5\" cannot be updated: the object has been modified; please apply your changes to the latest version and try again\n\nerror:\nexit status 1\n",
        }
        Error running &{/var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/kubernetes/platforms/linux/amd64/kubectl [kubectl --server=https://104.154.107.48 --kubeconfig=/var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/.kube/config rolling-update e2e-test-nginx-rc --update-period=1s --image=gcr.io/google_containers/nginx:1.7.9 --image-pull-policy=IfNotPresent --namespace=e2e-tests-kubectl-uyuh7] []  <nil> Error updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 3 secondsError updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 9 secondsError updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 81 seconds Error from server: pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again
         [] <nil> 0xc208561300 exit status 1 <nil> true [0xc2083b6460 0xc2083b6480 0xc2083b64a0] [0xc2083b6460 0xc2083b6480 0xc2083b64a0] [0xc2083b6478 0xc2083b6498] [0x968650 0x968650] 0xc208393a40}:
        Command stdout:
        Error updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 3 secondsError updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 9 secondsError updating pod (pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again), retrying after 81 seconds
        stderr:
        Error from server: pods "e2e-test-nginx-rc-9s4g5" cannot be updated: the object has been modified; please apply your changes to the latest version and try again

        error:
        exit status 1

    not to have occurred

    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/util.go:1593

@janetkuo
Copy link
Member

@k8s-bot e2e test this issue: #IGNORE

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

12 similar comments
@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

No test results found.

@k8s-bot
Copy link

k8s-bot commented Jun 20, 2016

GCE e2e build/test failed for commit 02e044a.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@eparis
Copy link
Contributor

eparis commented Jun 20, 2016

Removing LGTM to shut up the bot.
@lavalamp I think the bot is angry, likely because verification isn't run on the release-1.2 branch?

@eparis eparis removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2016
@eparis
Copy link
Contributor

eparis commented Jun 20, 2016

@roberthbailey you probably want to merge this by hand....

@eparis
Copy link
Contributor

eparis commented Jun 20, 2016

@spxtr @ixdy @kubernetes/sig-testing
What are the No test results found. complaints? Is that because this is for the release-1.2 branch?

@jayunit100
Copy link
Member

Looks like https://issues.jenkins-ci.org/plugins/servlet/mobile#issue/JENKINS-31103 some kinda weird Jenkins SHA limit thingy?

@lavalamp
Copy link
Member

Maybe #27685 is the culprit?

@fabioy
Copy link
Contributor

fabioy commented Jun 21, 2016

I think we need to merge this to to get the "kubernetes-test-go-release-1.2" Jenkins working again. Manual merge?

@roberthbailey roberthbailey merged commit a5845a4 into kubernetes:release-1.2 Jun 21, 2016
@ixdy
Copy link
Member

ixdy commented Jun 21, 2016

No idea what happened here. @kubernetes/test-infra-maintainers did we break PR Jenkins for 1.2 somehow?

@eparis
Copy link
Contributor

eparis commented Jun 21, 2016

So the merge-bot is angry because 'Jenkins verification' is never run on release-1.2.

That's a merge-bot problem, but it doesn't explain the k8s-bot responses. That's a different bot problem for the test-infra team.

@roberthbailey
Copy link
Contributor

@fabioy kubernetes-test-go-release-1.2 failed on the run after this PR was merged into the release branch. Any other ideas of how to fix that test on the release branch?

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#27113 from AdoHe/automated-cherry-pick-…
00dcea5 
…of-#26418-upstream-release-1.2

Automated cherry pick of kubernetes#26418
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@roberthbailey
Merge pull request kubernetes#27113 from AdoHe/automated-cherry-pick-…
51b0a9b 
…of-#26418-upstream-release-1.2

Automated cherry pick of kubernetes#26418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

@roberthbailey roberthbailey

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.