Improve petset e2es #26913
Merged
Improve petset e2es #26913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XL
| @@ -51,6 +52,9 @@ const ( | |||
| redisManifestPath = "test/e2e/testing-manifests/petset/redis" | |||
| ) | |||
|
|
|||
| // Time: 25m, slow by design. | |||
| // GCE Quota requirements: 3 pds, one per pet manifest declared above. | |||
| // GCE Api requirements: nodes and master need storage r/w permissions. | |||
| var _ = framework.KubeDescribe("PetSet", func() { | |||
There was a problem hiding this comment.
Add "[Slow]" to description, since this is slow by design.
bprashanth
force-pushed
the
petset_e2e
branch
2 times, most recently
from
90053ac to
bbe019b
Compare
bprashanth
added
release-note-none
j3ffml
added
the
lgtm
j3ffml
added
priority/important-soon
k8s-github-robot
added
size/L
k8s-github-robot
added
size/XL
|
@jlowdermilk PTAL I added a new commit to explicitly join new members to zookeeper master, if there is one |
|
Still lgtm, but please squash commits. |
j3ffml
added
the
lgtm
bprashanth
added
lgtm
|
GCE e2e build/test passed for commit ff23a0e. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit ff23a0e. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly
kubernetes/test-infra#115, #26824