Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try executing bash variable in assignment. #26195

Merged
merged 1 commit into from
May 24, 2016
Merged

Don't try executing bash variable in assignment. #26195

merged 1 commit into from
May 24, 2016
+2 −2

Conversation

Q-Lee
Copy link
Contributor

@Q-Lee Q-Lee commented May 24, 2016 

* Use the release-note-* labels to set the release note state 
* Clear this block to use the PR title as the release note 
-OR-
* Enter your extended release note here

Analytics

@Q-Lee Q-Lee added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 24, 2016
@Q-Lee
Copy link
Contributor Author

Q-Lee commented May 24, 2016

This should fix the GCI problem from #26109 and #26159

@goltermann goltermann added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 24, 2016
@goltermann
Copy link
Contributor

@k8s-oncall please merge this manually

@k8s-bot
Copy link

k8s-bot commented May 24, 2016

GCE e2e build/test passed for commit 3ca4c36.

@zmerlynn zmerlynn self-assigned this May 24, 2016
@zmerlynn
Copy link
Member

I'm just going to merge this. This is a clear GCI cluster bring-up issue.

@zmerlynn zmerlynn merged commit 6e4f494 into kubernetes:master May 24, 2016
@yujuhong yujuhong mentioned this pull request May 24, 2016
Closed
@yujuhong
Copy link
Contributor

Thanks for fixing this!

Another fix #26190 was uploaded and waiting to be merged by the oncall an hour before this PR. It might have saved everyone time if the oncall was involved in the decision of merging :-)

This was referenced May 24, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@roberthbailey roberthbailey mentioned this pull request May 24, 2016
Merged
@girishkalele girishkalele mentioned this pull request May 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Q-Lee @goltermann @k8s-bot @zmerlynn @yujuhong @googlebot