GCI: fix a breakage in controller-manager #25984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
andyzheng0831
added
release-note-none
|
LGTM |
|
I verified this fix by running k8s e2e tests. All passed. Safe to merge. The default ContainerVM-based test will not cover this fix. Mark it as e2e-not-required. Considering the PR breaking GCI is p0, and currently both GCI k8s ci and GKE ci are blocked, prefer to mark this fix as P1 |
andyzheng0831
added
e2e-not-required
priority/important-soon
|
@mikedanese please add a lgtm label so it can be in queue |
|
I manually merged |
mikedanese
added
the
lgtm
|
GCE e2e build/test passed for commit 728be28. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the breakage to GCI caused by PR #19242.