Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Metrics API in HPA #25768

Merged
merged 2 commits into from
May 22, 2016
Merged

Use Metrics API in HPA #25768

merged 2 commits into from
May 22, 2016

Conversation

piosz
Copy link
Member

@piosz piosz commented May 17, 2016 •
edited
Loading

No description provided.

@piosz piosz added the release-note-none Denotes a PR that doesn't merit a release note. label May 17, 2016
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2016
mwielgus
mwielgus reviewed May 17, 2016
View reviewed changes
pkg/controller/podautoscaler/metrics/metrics_client.go
@@ -118,7 +118,7 @@ func (h *HeapsterMetricsClient) GetCpuConsumptionAndRequestInMillis(namespace st
if err != nil {
return 0, 0, time.Time{}, fmt.Errorf("failed to get pod list: %v", err)
}
podNames := []string{}
podNames := map[string]bool{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struct{} has only one value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, though personally I don't like this structure.

@piosz piosz force-pushed the metrics-api-hpa branch from 2faf129 to df58830 Compare May 19, 2016 19:29
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2016
@piosz piosz force-pushed the metrics-api-hpa branch from df58830 to f5df90c Compare May 20, 2016 12:12
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2016
@piosz piosz force-pushed the metrics-api-hpa branch 3 times, most recently from 16c8a4c to 626388e Compare May 20, 2016 15:10
@piosz piosz added this to the v1.3 milestone May 20, 2016
@piosz piosz force-pushed the metrics-api-hpa branch from 626388e to f2cec5e Compare May 20, 2016 15:45
@piosz piosz changed the title WIP: Use Metrics API in HPA Use Metrics API in HPA May 20, 2016
@piosz piosz force-pushed the metrics-api-hpa branch from f2cec5e to 26ad827 Compare May 20, 2016 17:51
@piosz
Copy link
Member Author

piosz commented May 20, 2016

@k8s-bot unit test this issue: #IGNORE

@piosz
Copy link
Member Author

piosz commented May 20, 2016

@mwielgus comments applied, tests fixed. PTAL

@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 22, 2016

GCE e2e build/test passed for commit 26ad827.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1b78799 into kubernetes:master May 22, 2016
@piosz piosz deleted the metrics-api-hpa branch May 23, 2016 05:23
@piosz piosz mentioned this pull request May 23, 2016
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mwielgus mwielgus

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@piosz @mwielgus @k8s-github-robot @k8s-bot @0xmichalis @googlebot