Configuration for GCP webhook authentication. #25380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcullen
added
release-note-none
cjcullen
force-pushed
the
gcpauthentication
branch
from
d773a8a to
28ae690
Compare
zmerlynn
added
the
lgtm
k8s-github-robot
added
the
size/M
erictune
added
the
priority/important-soon
cjcullen
force-pushed
the
gcpauthentication
branch
from
28ae690 to
4e01d4f
Compare
k8s-github-robot
removed
the
lgtm
|
Rebased. |
cjcullen
added
the
lgtm
|
GCE e2e build/test passed for commit 4e01d4f. |
|
@cjcullen PR needs rebase |
k8s-github-robot
added
the
needs-rebase
This was referenced May 12, 2016
k8s-github-robot
pushed a commit
that referenced
this pull request
May 22, 2016
Automatic merge from submit-queue Configuration for GCP webhook authentication and authorization This PR adds configuration for GCP webhook authentication and authorization in ContainerVM and GCI. The change of configure-vm.sh and kube-apiserver.manifest is directly copied from @cjcullen's PR #25380 and #25296. The change in GCI script configure-helper.sh includes the support for webhook authentication and authorization, and also some code refactor to improve readability. @cjcullen @roberthbailey @zmerlynn please review it. The original PRs are P1, please mark this as P1. cc/ @fabioy @kubernetes/goog-image FYI. I verified it by running e2e tests on GCI cluster. Without the GCI side change, cluster creation fails as being capture by GKE Jenkins tests. I don't test when the two env GCP_AUTHN_URL and GCP_AUTHZ_URL are set, because they are only set in GKE. After this PR is merged, @cjcullen will test in GKE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb through webhook authentication config on GCE.
This depends on #24902 (which will hopefully be merged shortly) to actually work.