Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getCloudProvider retries to getCloudProvider() #25179

Merged
merged 1 commit into from May 6, 2016
Merged

Move getCloudProvider retries to getCloudProvider() #25179

merged 1 commit into from May 6, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2016

Splitting this off form #21709

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels May 5, 2016
@k8s-github-robot
Copy link

@swagiaal
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-bot
Copy link

k8s-bot commented May 5, 2016

GCE e2e build/test passed for commit d1aacfc.

@ghost ghost assigned saad-ali and unassigned pmorie May 5, 2016
@saad-ali
Copy link
Member

saad-ali commented May 5, 2016

LGTM

Retrying is not as critical anymore anyway since PR #23769 changed to use the cloud provider object pre-constructed by the binary instead of creating a new one everytime which is much less likely to fail.

@saad-ali saad-ali added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 5, 2016
@k8s-github-robot k8s-github-robot assigned pmorie and unassigned saad-ali May 6, 2016
@roberthbailey roberthbailey merged commit f6a6846 into kubernetes:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants