Trusty: Handle the new var in kube-proxy manifest #24531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
|
GCE e2e build/test passed for commit 7772b7f. |
cjcullen
added
release-note-none
zmerlynn
added
the
priority/critical-urgent
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
zmerlynn
added
the
cherry-pick-approved
|
GCE e2e build/test passed for commit 7772b7f. |
|
Automatic merge from submit-queue |
|
@andyzheng0831: Please prepare a cherrypick PR ASAP and I'll get it merged, thanks! |
|
Cherry pick PR is made #24531 |
zmerlynn
added a commit
that referenced
this pull request
Apr 20, 2016
…-#24531-upstream-release-1.2 Automated cherry pick of #24531
|
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ry-pick-of-#24531-upstream-release-1.2 Automated cherry pick of kubernetes#24531
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ry-pick-of-#24531-upstream-release-1.2 Automated cherry pick of kubernetes#24531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to capture the kube-proxy manifest change in PR #24429.
@roberthbailey @fabioy @zmerlynn please review this change and mark it as cherry pick candidate. We need to catch up 1.2.3 release.
cc/ @dchen1107 @wonderfly @cjcullen FYI.
I have verified this fix. Without this fix, kube-proxy pod in Trusty nodes cannot be started correctly, i.e., the command line has an unhadled variable. And some other kube-system pods do not work correctly as kube-proxy is not working well. After applying this fix, kube-proxy can be started correctly, and all kube-system pods run successfully.