Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version-guard Kubectl client Guestbook application test against deployments #24342

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Version-guard Kubectl client Guestbook application test against deployments #24342

merged 1 commit into from
Apr 15, 2016

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Apr 15, 2016

Fixes #24159; related to #16040.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-bot
Copy link

k8s-bot commented Apr 15, 2016

GCE e2e build/test failed for commit 1586fc5f7ea6dce89a1deccc2fd6a276c4f78d9e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@janetkuo
Copy link
Member

LGTM. Thanks!

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 15, 2016

GCE e2e build/test passed for commit a96bb71.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d34e7c3 into kubernetes:master Apr 15, 2016
@roberthbailey roberthbailey added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 19, 2016
@roberthbailey
Copy link
Contributor

@ihmccreery Please create a cherry pick pull for this PR.

@ikehz
Copy link
Contributor Author

ikehz commented Apr 19, 2016

@roberthbailey #24478.

zmerlynn added a commit that referenced this pull request Apr 20, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test area/upgrade cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants