Trusty: Avoid unnecessary in-memory temp files #24144
Merged
+59
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/L |
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit 988f16a. |
zmerlynn
added
lgtm
|
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ry-pick-of-#24144-upstream-release-1.2 Automatic merge from submit-queue Automated cherry pick of kubernetes#24144 Cherry pick of kubernetes#24144 on release-1.2.
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ry-pick-of-#24144-upstream-release-1.2 Automatic merge from submit-queue Automated cherry pick of kubernetes#24144 Cherry pick of kubernetes#24144 on release-1.2.
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Dec 7, 2019
…ions [release-4.2] Bug 1772087: Fix RS expectations Origin-commit: 8fb3cf371d4b1985c3e2a27b634471f156da6c1a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an enhancement to reducing memory usage by avoiding unnecessary in-memory temp files. We used to put many kubernetes files (such as docker images of the kube-system pods) in /run, which typically is mounted with tmpfs. As a result, there are hundreds of MB memory occupied by these files. In this PR, we move kubernetes files under /home/kubernetes to get rid of those in-memory temp files.
I have manually run e2e using "go run ./hack/e2e.go -v --test '--test_args=--ginkgo.skip=[Skipped]|[Feature:.+]|[Serial]|[Disruptive]|[Flaky]|[Slow]'"
@dchen1107 @roberthbailey please review it. It would be nice to also cherry pick in release-1.2.
cc/ @fabioy @wonderfly FYI.