Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #24008 #24135

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 12, 2016

Cherry pick of #24008 on release-1.2.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2016
@liggitt
Copy link
Member Author

liggitt commented Apr 12, 2016

cc @roberthbailey @zmerlynn

@k8s-bot
Copy link

k8s-bot commented Apr 12, 2016

GCE e2e build/test passed for commit 10ad406.

@k8s-github-robot k8s-github-robot added this to the v1.2 milestone Apr 13, 2016
@k8s-github-robot k8s-github-robot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 13, 2016
@liggitt
Copy link
Member Author

liggitt commented Apr 13, 2016

@k8s-bot unit test this issue: #24207

@liggitt liggitt removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 14, 2016
@liggitt liggitt assigned wojtek-t and unassigned smarterclayton Apr 14, 2016
@liggitt
Copy link
Member Author

liggitt commented Apr 14, 2016

@wojtek-t PTAL

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2016
@wojtek-t
Copy link
Member

LGTM

@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

GCE e2e build/test passed for commit 10ad406.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 14, 2016

GCE e2e build/test passed for commit 10ad406.

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 14, 2016
@lavalamp lavalamp merged commit 22e7950 into kubernetes:release-1.2 Apr 14, 2016
@liggitt liggitt deleted the automated-cherry-pick-of-#24008-upstream-release-1.2 branch August 22, 2016 01:01
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…k-of-#24008-upstream-release-1.2

Automated cherry pick of kubernetes#24008
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…k-of-#24008-upstream-release-1.2

Automated cherry pick of kubernetes#24008
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Nov 18, 2019
Bug 1767295: UPSTREAM: 84466: gce: skip ensureInstanceGroup for a zone that has no remaining nodes for k8s managed IG

Origin-commit: 2af6d240087e52e8e635bb4ca406282c401271cf
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Dec 9, 2019
Bug 1767295: UPSTREAM: 84466: gce: skip ensureInstanceGroup for a zone that has no remaining nodes for k8s managed IG

Origin-commit: 2af6d240087e52e8e635bb4ca406282c401271cf
p0lyn0mial pushed a commit to p0lyn0mial/kubernetes that referenced this pull request Dec 20, 2019
Bug 1767295: UPSTREAM: 84466: gce: skip ensureInstanceGroup for a zone that has no remaining nodes for k8s managed IG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants