Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #23793 #23935

Conversation

mikedanese
Copy link
Member

Cherry pick of #23793 on release-1.2.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@mikedanese
Copy link
Member Author

Closes #23825 cc @pmorie

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 6, 2016
@pmorie pmorie added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 6, 2016
@pmorie
Copy link
Member

pmorie commented Apr 6, 2016

This seems significant enough that there should be a release note for 1.2.1, but I'm not certain whether this issue title is going to be descriptive enough. Thoughts @mikedanese ?

@mikedanese
Copy link
Member Author

@pmorie Release notes should come from the title of the original PR if I'm not mistaken. Should merge-bot add this label on cherry pick PRs? Is that correct @eparis @david-mcmahon ?

@david-mcmahon
Copy link
Contributor

Yes, your original master PR title is the release note - https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes

@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit d964c00.

@zmerlynn zmerlynn removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 6, 2016
@zmerlynn zmerlynn assigned zmerlynn and unassigned pmorie Apr 6, 2016
@zmerlynn zmerlynn merged commit 3d9cf1e into kubernetes:release-1.2 Apr 6, 2016
@mikedanese mikedanese deleted the automated-cherry-pick-of-#23793-upstream-release-1.2 branch April 6, 2016 23:03
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…pick-of-#23793-upstream-release-1.2

Automated cherry pick of kubernetes#23793
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…pick-of-#23793-upstream-release-1.2

Automated cherry pick of kubernetes#23793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants