Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #23550 upstream release 1.2 #23783

Conversation

luxas
Copy link
Member

@luxas luxas commented Apr 2, 2016

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 2, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 2, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 2, 2016

GCE e2e build/test failed for commit 9755054.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

@zmerlynn Can you kindly LGTM this?
The main PR already has the cherrypick-approved label, so I think you should just remove do-not-merge and release-note-label-needed and add lgtm, release-note and maybe ok-to-merge
Thanks

@zmerlynn zmerlynn added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 6, 2016
@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

@k8s-bot test this please github issue: #IGNORE

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

Removing LGTM because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-none", or "release-note-action-required"
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/release-notes.md

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 6, 2016
@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

Ah, the bots don't really like us.
@eparis Should the cherrypick-candidate label be applied on this PR also?

@david-mcmahon
Copy link
Contributor

@eparis we need to update the procedure to follow the current cherry pick process. I know this changed right after we 'finalized' it and apologies for that, but if we can change it so that it follows the new procedure of not requiring any accounting on the cherrypick/branch side, that would be good. Also, can you point to [cherry-pick info] - rather than the proposal - in the bot message?

@roberthbailey roberthbailey added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 6, 2016
@roberthbailey roberthbailey removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 6, 2016
@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

Please add one of release-note|release-note-none. The main PR has the release-note label

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 6, 2016
@k8s-github-robot
Copy link

Removing LGTM because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-none", or "release-note-action-required"
Please see: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/release-notes.md

@k8s-github-robot k8s-github-robot added release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 6, 2016
@zmerlynn
Copy link
Member

zmerlynn commented Apr 6, 2016

@luxas: I thought you only needed it on the main PR, but the bot gets angry if it's not on both. We need to fix that, there's too many twiddles here.

@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 6, 2016
@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

I also thought it was only required on the master PR, but it doesn't seem so

@k8s-bot
Copy link

k8s-bot commented Apr 6, 2016

GCE e2e build/test passed for commit 9755054.

@luxas
Copy link
Member Author

luxas commented Apr 6, 2016

I think the bot will be angry if not the cherrypick-approved label is here also. Not sure if the v1.2 milestone is required.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 6, 2016
@david-mcmahon
Copy link
Contributor

Yes, this has been a very dynamic process and not all of the changes are in sync as we get things in place. There's a pending PR as well to get all of the docs in sync on this. Comments welcome

@roberthbailey roberthbailey added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 6, 2016
@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@zmerlynn zmerlynn merged commit 07899b4 into kubernetes:release-1.2 Apr 6, 2016
@eparis
Copy link
Contributor

eparis commented Apr 6, 2016

Had the PR been opened using the scripts it would have automatically gotten the 'cherrypick-approved' label when the 'parent' PR has it.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…of-#23550-upstream-release-1.2

Automated cherry pick of kubernetes#23550 upstream release 1.2
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…of-#23550-upstream-release-1.2

Automated cherry pick of kubernetes#23550 upstream release 1.2
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Oct 2, 2019
Bug 1752045: UPSTREAM: <carry>:Add a RBAC checker for external IP ranger

Origin-commit: 57f1e30c88eb41aacb4bc791627089c8b820be2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants