-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #23550 upstream release 1.2 #23783
Automated cherry pick of #23550 upstream release 1.2 #23783
Conversation
This PR is not for the master branch but does not have the |
Labelling this PR as size/M |
GCE e2e build/test failed for commit 9755054. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
@zmerlynn Can you kindly LGTM this? |
@k8s-bot test this please github issue: #IGNORE |
This PR is not for the master branch but does not have the |
Removing LGTM because the release note process has not been followed. |
Ah, the bots don't really like us. |
@eparis we need to update the procedure to follow the current cherry pick process. I know this changed right after we 'finalized' it and apologies for that, but if we can change it so that it follows the new procedure of not requiring any accounting on the cherrypick/branch side, that would be good. Also, can you point to [cherry-pick info] - rather than the proposal - in the bot message? |
Please add one of |
This PR is not for the master branch but does not have the |
Removing LGTM because the release note process has not been followed. |
@luxas: I thought you only needed it on the main PR, but the bot gets angry if it's not on both. We need to fix that, there's too many twiddles here. |
I also thought it was only required on the master PR, but it doesn't seem so |
GCE e2e build/test passed for commit 9755054. |
I think the bot will be angry if not the |
This PR is not for the master branch but does not have the |
Yes, this has been a very dynamic process and not all of the changes are in sync as we get things in place. There's a pending PR as well to get all of the docs in sync on this. Comments welcome |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
Had the PR been opened using the scripts it would have automatically gotten the 'cherrypick-approved' label when the 'parent' PR has it. |
…of-#23550-upstream-release-1.2 Automated cherry pick of kubernetes#23550 upstream release 1.2
…of-#23550-upstream-release-1.2 Automated cherry pick of kubernetes#23550 upstream release 1.2
Bug 1752045: UPSTREAM: <carry>:Add a RBAC checker for external IP ranger Origin-commit: 57f1e30c88eb41aacb4bc791627089c8b820be2d
Ref: #23550
@fgrzadkowski @vishh @bgrant0607 @thockin @david-mcmahon @huggsboson