YAML unit/integration job. #23696
YAML unit/integration job. #23696
Conversation
spxtr
added
area/test-infra
e2e-not-required
do-not-merge
k8s-github-robot
added
the
size/L
|
The prereq check was handy, since we've occasionally had Docker and gcloud go AWOL before, failing large swaths of PRs, though some process which instead took bad nodes offline would probably be better (since we'd be more likely to notice). |
| - wojtek-t | ||
| - yujuhong | ||
| - zmerlynn | ||
| white-list: |
There was a problem hiding this comment.
hm. should we get rid of the "add to white-list" functionality and require updates to this instead? (that's probably preferable, anyway)
There was a problem hiding this comment.
ok, I've updated the PR Jenkins config/comment to note this. (it will be a little confusing for a bit, since this config isn't checked in, but I'll field the complaints.)
| - goltermann | ||
| - ihmccreery | ||
| - ixdy | ||
| - JanetKuo |
|
Assigning back to you. Assign back to me when you've addressed feedback. |
|
@ixdy For the most part the admin list lines up with kubernetes-maintainers, but I don't think that's ever been an actual policy, and many people are in both kubernetes-maintainers and kubernetes-collaborators, or neither, since kubernetes members are auto-whitelisted. |
spxtr
added
release-note-none
| </patterns> | ||
| <deleteDirs>true</deleteDirs> | ||
| <cleanupParameter/> | ||
| <externalDelete>sudo rm -rf %s</externalDelete> |
There was a problem hiding this comment.
|
@ixdy PTAL |
|
GCE e2e build/test passed for commit 84c0fd6. |
|
@spxtr PR needs rebase |
k8s-github-robot
added
the
needs-rebase
|
Will remake shortly. |
This is blocked on #23415, and I'll need to tweak it a bit to get upload-started going, but I think this is about how it'll look.
Two small changes. There's no more 'skip ci' comment, and I don't think anyone was using that, and there's no more slave prerequisite check. Not sure if those are big deals.