Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #23646 #23685

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Automated cherry pick of #23646 #23685

merged 1 commit into from
Mar 31, 2016

Conversation

cjcullen
Copy link
Member

Cherry pick of #23646 on release-1.2.

@cjcullen
Copy link
Member Author

@bgrant0607

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 31, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 31, 2016

GCE e2e build/test passed for commit 77bcd14.

@cjcullen cjcullen assigned bgrant0607 and unassigned eparis Mar 31, 2016
@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 31, 2016
@bgrant0607 bgrant0607 added this to the v1.2 milestone Mar 31, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 31, 2016
@eparis eparis added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 31, 2016
@bgrant0607
Copy link
Member

Merging.

@bgrant0607 bgrant0607 merged commit 12d7dec into kubernetes:release-1.2 Mar 31, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607
Merge pull request kubernetes#23685 from cjcullen/automated-cherry-pi…
4e051e8 
…ck-of-#23646-upstream-release-1.2

Automated cherry pick of kubernetes#23646
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607
Merge pull request kubernetes#23685 from cjcullen/automated-cherry-pi…
6c1fc83 
…ck-of-#23646-upstream-release-1.2

Automated cherry pick of kubernetes#23646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@cjcullen @k8s-github-robot @k8s-bot @bgrant0607 @k8s-teamcity-mesosphere @googlebot @eparis