Revert "Merge pull request #22893 from Q-Lee/nanny-heapster" #23499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
LGTM |
|
Heapster image was not reverted. I'll let @Q-Lee take a look, since the revert was partly manual. |
|
GCE e2e build/test passed for commit b4739b5. |
|
Ok beyond the revert, I need to rename the heapster controller names that change in #23470 to play well with get-suffix. See second commit. While the update probably would work, I think it could cause issues with a later update of heapster. cc @piosz |
|
GCE e2e build/test passed for commit 71614ff. |
|
@mikedanese PR needs rebase |
k8s-github-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1f8773e, reversing
changes made to 9dfbcae.
Reverts #22893. This was a manual revert since #23470 had created some conflicts.
Ref #23470
cc @Q-Lee @fgrzadkowski @piosz @bgrant0607