Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate gke-trusty test jobs to 1.2 #23454

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Migrate gke-trusty test jobs to 1.2 #23454

merged 1 commit into from
Apr 1, 2016
+75 −35

Conversation

wonderfly
Copy link
Contributor

Following up #23100 and #23139, #23319, migrate all gke-trusty jobs to the
release-1.2 branch, add parallel and subnet test jobs, and bump timeouts
accordingly.

Tested with jenkins-jobs test. Manually diff'ed gke-trusty jobs against their equivalent gke jobs. For example,

# diff /tmp/jobs0324/kubernetes-e2e-gke-test /tmp/jobs0324/kubernetes-e2e-gke-trusty-test
4c4
<   <description>Run E2E tests on GKE test endpoint. Test owner: GKE on-call.&lt;!-- Managed by Jenkins Job Builder --&gt;</description>

---
>   <description>Run E2E tests on GKE test endpoint. Test owner: wonderfly@google.com.&lt;!-- Managed by Jenkins Job Builder --&gt;</description>
49c49
< export PROJECT=&quot;k8s-jkns-e2e-gke-test&quot;

---
> export PROJECT=&quot;kubekins-e2e-gke-trusty-test&quot;
51a52
> export E2E_NAME=&quot;jkns-gke-e2e-test-trusty&quot;
228c229
<       <recipientList>$DEFAULT_RECIPIENTS</recipientList>

---
>       <recipientList>wonderfly@google.com,qzheng@google.com</recipientList>

@spxtr @roberthbailey @ihmccreery Can you review this?
cc/ @andyzheng0831

@roberthbailey
Copy link
Contributor

@spxtr is out today -- @ihmccreery can you take a look? you're more familiar with this yaml syntax than I am.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 24, 2016

GCE e2e build/test passed for commit 1f2461e811bfd7f6430739889cabd9cb5abe08e9.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

@wonderfly PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2016
@wonderfly
Copy link
Contributor Author

Rebased

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 25, 2016

GCE e2e build/test passed for commit d0e64b7166f777e78cb09aa221a0148328b6603f.

@wonderfly
Copy link
Contributor Author

I think it still needs a LGTM tag. @ihmccreery Can you take a look?

@wonderfly
Copy link
Contributor Author

@ixdy Maybe you can take a look if both @spxtr and @ihmccreery are out?

@andyzheng0831
Copy link

@wonderfly Since this PR has not got lgtm, I would suggest you to revise it to adapt to #23466. Otherwise, you will have to make another PR, review, and waiting for merge, which will be a long cycle again.

ikehz
ikehz reviewed Mar 28, 2016
View reviewed changes
hack/jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e.yaml
export PROJECT="kubekins-e2e-gke-trusty-test"
export CLOUDSDK_BUCKET="gs://cloud-sdk-testing/rc"
export JENKINS_USE_SERVER_VERSION="y"
export E2E_NAME="jkns-gke-e2e-test-trusty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since each of these is running in a separate project, please don't use E2E_NAME, and let it default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of E2E_NAME won't have the -trusty suffix, which is required to start a GKE cluster with Trusty images. @roberthbailey can give the context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an explanation comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ikehz
Copy link
Contributor

ikehz commented Mar 28, 2016

Why do you want to test against all our different endpoints? Seems like a lot to me.

@wonderfly
Copy link
Contributor Author

@wonderfly Since this PR has not got lgtm, I would suggest you to revise it to adapt to #23466. Otherwise, you will have to make another PR, review, and waiting for merge, which will be a long cycle again.

@andyzheng0831 Done.

@wonderfly
Copy link
Contributor Author

Why do you want to test against all our different endpoints? Seems like a lot to me.

Because we want to qualify a Trusty image the same way we qualify a ContainerVM today, i.e., soak it in test and staging for a while, before pushing it to prod. In fact, if you look at our internal Jenkins instance, we have been doing so for a while. This PR just moves them from 1.1 to 1.2.

@wonderfly
Copy link
Contributor Author

@ihmccreery Addressed comments. PTAL when you have time.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2016
@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2016
@wonderfly
Copy link
Contributor Author

Ah, I lost my precious LGTM by updating one line of comments. :(

@ihmccreery

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test failed for commit fd8155f02953b6593f7dae518de522372cbe49d0.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Mar 28, 2016

GCE e2e build/test passed for commit f46f9a4626260f334c6ec0a2869ce599335552a3.

@wonderfly wonderfly mentioned this pull request Mar 28, 2016
Closed
@wonderfly
Copy link
Contributor Author

@ihmccreery Can you please re-grant LGTM?

@ikehz ikehz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2016
@wonderfly
Migrate gke-trusty test jobs to 1.2
a84f4c2 
Following up kubernetes#23100 and kubernetes#23139, kubernetes#23319, migrate all gke-trusty jobs to the
`release-1.2` branch, add parallel and subnet test jobs, and bump timeouts
accordingly.
@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 30, 2016

GCE e2e build/test passed for commit a84f4c2.

@wonderfly
Copy link
Contributor Author

@ihmccreery I rebased the PR, but don't think anything has changed. Can you give LGTM again?

@ikehz ikehz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 30, 2016

GCE e2e build/test passed for commit a84f4c2.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 30, 2016

GCE e2e build/test passed for commit a84f4c2.

@eparis eparis added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 31, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 1, 2016

GCE e2e build/test passed for commit a84f4c2.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 14f5eb4 into kubernetes:master Apr 1, 2016
wonderfly added a commit to wonderfly/kubernetes that referenced this pull request May 2, 2016
@wonderfly
Remove obsolete Trusty e2e test jobs
eb6aab9 
PRs kubernetes#23454 and kubernetes#25042 moved Trusty GKE and Beta e2e test jobs to 1.2.
@wonderfly wonderfly mentioned this pull request May 2, 2016
Merged
@wonderfly wonderfly deleted the bump_timeouts branch June 8, 2016 21:30
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@wonderfly
Remove obsolete Trusty e2e test jobs
f2a890a 
PRs kubernetes#23454 and kubernetes#25042 moved Trusty GKE and Beta e2e test jobs to 1.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ikehz ikehz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wonderfly @roberthbailey @k8s-github-robot @k8s-bot @andyzheng0831 @ikehz @k8s-teamcity-mesosphere @googlebot @eparis