Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee we finish writing to the test log before the test exits. #22727

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Guarantee we finish writing to the test log before the test exits. #22727

merged 1 commit into from
Mar 11, 2016

Conversation

mml
Copy link
Contributor

@mml mml commented Mar 9, 2016

Should fix #22614

@mml mml mentioned this pull request Mar 9, 2016
Closed
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 9, 2016

GCE e2e build/test passed for commit 385c8837579ca625cc69aaaad64a6b2e0225fa62.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 9, 2016

GCE e2e build/test passed for commit 547c3b4.

@mml
Copy link
Contributor Author

mml commented Mar 10, 2016

@k8s-bot Probar esto, por favor.

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 10, 2016
@davidopp
Copy link
Member

LGTM

@k8s-github-robot
Copy link

@mml
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2016
@mml
Copy link
Contributor Author

mml commented Mar 11, 2016

@k8s-bot good grief, it's just because the travis build timed out..

@mml mml closed this Mar 11, 2016
@mml mml reopened this Mar 11, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 547c3b4.

@goltermann goltermann added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Mar 11, 2016
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR has added the cherrypick-candidate label but did not set a milestone. This is an invalid state and will not be considered for cherrypick-ing to any release branch. The cherrypick-candidate label will be automatically removed from such PRs in the future.

@mml mml added this to the v1.2 milestone Mar 11, 2016
@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
@bgrant0607
Copy link
Member

Manually merging. @k8s-oncall

bgrant0607 added a commit that referenced this pull request Mar 11, 2016
@bgrant0607
Merge pull request #22727 from mml/racey
ac068cd 
Guarantee we finish writing to the test log before the test exits.
@bgrant0607 bgrant0607 merged commit ac068cd into kubernetes:master Mar 11, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22727 from mml/racey
f9762c0 
Guarantee we finish writing to the test log before the test exits.
@eparis eparis mentioned this pull request Mar 11, 2016
Merged
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR is included in #22874 which is slated to be included in the release-1.2 branch.
Please verify that the cherry-pick in that PR looks correct.

@eparis eparis removed cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
@mml
Copy link
Contributor Author

mml commented Mar 12, 2016

Verified.

On Fri, Mar 11, 2016 at 1:49 PM Eric Paris notifications@github.com wrote:

This PR is included in #22874
#22874 which is slated to
be included in the release-1.2 branch.
Please verify that the cherry-pick in that PR looks correct.

—
Reply to this email directly or view it on GitHub
#22727 (comment)
.

@mml mml deleted the racey branch March 16, 2016 21:31
@mml mml mentioned this pull request Mar 31, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22727 from mml/racey
89e3d9e 
Guarantee we finish writing to the test log before the test exits.
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607 @eparis
Merge pull request kubernetes#22727 from mml/racey
3c73fdf 
Guarantee we finish writing to the test log before the test exits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

unit test flake: TestSchedulerForgetAssumedPodAfterDelete race
9 participants
@mml @k8s-github-robot @k8s-bot @davidopp @eparis @bgrant0607 @k8s-teamcity-mesosphere @googlebot @goltermann