Enable --log-level=info for docker daemons for scalability jenkins jo… #22453
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
| @@ -69,6 +69,7 @@ ENABLE_CLUSTER_MONITORING="${KUBE_ENABLE_CLUSTER_MONITORING:-influxdb}" | |||
| # Default Log level for all components in test clusters and variables to override it in specific components. | |||
| TEST_CLUSTER_LOG_LEVEL="${TEST_CLUSTER_LOG_LEVEL:---v=4}" | |||
| KUBELET_TEST_LOG_LEVEL="${KUBELET_TEST_LOG_LEVEL:-$TEST_CLUSTER_LOG_LEVEL}" | |||
| DOCKER_TEST_LOG_LEVEL="${DOCKER_TEST_LOG_LEVEL:---log-level=info}" | |||
There was a problem hiding this comment.
Why have it default to info instead of empty?
- That's redundant with the change in
kubernetes-e2e.yaml; - If the default drifts elsewhere, this default won't drift with it, which is probably bad.
There was a problem hiding this comment.
kubernetes-e2e.yaml only affects jenkins project. I also want to enable this for dev's e2e tests.
There was a problem hiding this comment.
Generally we'd prefer that test clusters look as similar to prod clusters as possible. cc @spxtr @kubernetes/goog-testing
|
I'm a bit skeptical of the default, otherwise LGTM. |
|
Also I know ~zero about the salt stuff, so @mikedanese should still review that. |
|
GCE e2e build/test passed for commit 84689a7. |
|
LGTM |
mikedanese
added
the
lgtm
| @@ -139,6 +139,8 @@ | |||
| export REGISTER_MASTER="true" | |||
| # Reduce logs verbosity | |||
| export TEST_CLUSTER_LOG_LEVEL="--v=2" | |||
| # TODO: Remove when we figure out #22166 and other docker potential slowness | |||
| export DOCKER_TEST_LOG_LEVEL="--log-level=info" | |||
There was a problem hiding this comment.
we probably don't need this, since it's also specified in config-test.sh?
dchen1107
added
priority/important-soon
j3ffml
added a commit
that referenced
this pull request
Mar 4, 2016
Enable --log-level=info for docker daemons for scalability jenkins jo…
|
This appears to have broken all gke e2e runs. I tried creating a test cluster and got the same failure. Tailing Reverting this to unbreak e2e, we can roll forward after. |
| @@ -7,5 +7,9 @@ | |||
| {% if pillar.get('network_provider', '').lower() == 'kubenet' %} | |||
| {% set bridge_opts = "" %} | |||
| {% endif -%} | |||
| DOCKER_OPTS="{{grains_opts}} {{e2e_opts}} {{bridge_opts}} --iptables=false --ip-masq=false --log-level=warn" | |||
| {% set log_level = pillar['log_level'] -%} | |||
There was a problem hiding this comment.
This should be:
{% set log_level = "--log-level=warn" -%}
or
{% set log_level = "" -%}
There was a problem hiding this comment.
My fault! Copy&paste this code and forgot to remove. Sorry about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…b and e2e test.
This should help with debugging #22166, #21866 and #22259