Make sure docker is properly shutdown before startup. #21703
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchen1107
added
priority/important-soon
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
| @@ -19,10 +19,21 @@ | |||
| # which in turn restarts docker. | |||
|
|
|||
| /etc/init.d/docker stop | |||
| # Make sure docker gracefully terminated before start again | |||
| while true; do | |||
There was a problem hiding this comment.
This can be compressed to:
while pidof docker > /dev/null; do
echo "waiting on clean docker shutdown"
sleep 10
done
|
GCE e2e test build/test passed for commit 60a37834802130e2d29f133115d093bec3b4ca4a. |
zmerlynn
added
the
lgtm
|
GCE e2e test build/test passed for commit 6c5f07d. |
|
I merge this one manually to stop tons of flake issues. |
dchen1107
added a commit
that referenced
this pull request
Feb 22, 2016
Make sure docker is properly shutdown before startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21261, #20908, ...
Partially resolve some issue with #21523