Cassandra example: daemonset volume fix, readme cleanup, update to new gcr image #21645
Conversation
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e test build/test passed for commit 3ad72d280f4b764ddb79d730a43bc18c4c99ff50. |
|
GCE e2e test build/test passed for commit c9839d984ec8b3681ada2430067a95dba8eaae9c. |
|
Neglected to add: towards issue #20961. |
| @@ -364,9 +452,18 @@ Create this daemonset: | |||
| $ kubectl create -f examples/cassandra/cassandra-daemonset.yaml | |||
| ``` | |||
|
|
|||
| Now if you list the pods in your cluster, and filter to the label ```name=cassandra```, you should see one cassandra pod for each node in your network: | |||
| Make sure that your Kubernetes cluster has enabled use of the experimental API. | |||
There was a problem hiding this comment.
This mention of the experimental api will be outdated in 1.2, so maybe I shouldn't even add it here.
There was a problem hiding this comment.
Yes, this shouldn't be true at HEAD and in 1.2. Please try this on HEAD to confirm that it works, and remove this.
|
Re. image sources, we have https://github.com/kubernetes/application-images |
|
Does this make the cassandra e2e test pass? |
|
Yes, we should remove pod adoption from here. |
| Cassandra `SeedProvider` is used to enable Cassandra to dynamically discover | ||
| new Cassandra nodes as they join the cluster. | ||
|
|
||
| This document also attempts to describe the core components of Kubernetes: |
There was a problem hiding this comment.
Maybe better as a bullet list.
amygdala
force-pushed
the
cassandra
branch
3 times, most recently
from
2d9d40b to
b915d8e
Compare
|
I changed the daemonset pod label key to 'app', so now those pods map to the cassandra service, and so now the cassandra seed provider works with just the daemonset pods. However, with this fix, I need to have the user shut down the rc before starting up the daemonset, else they fight with each other, thrashing back and forth, unless the number of rc replicas is the same as the number of nodes :). (hope that made sense). Also: #22158 I believe I've addressed the fixes/comments on the README. I'll do the pod adoption change in a following PR. |
|
LGTM, thanks! |
bgrant0607
added
the
lgtm
|
PR changed after LGTM, removing LGTM. |
k8s-github-robot
removed
the
lgtm
|
arghh, the push after the LGTM was just me 'kicking' the test process by rebasing with master and repushing. No changes to the code in the PR. I won't do that in future. The test process still seems wedged anyway. |
|
LGTM |
bgrant0607
added
the
lgtm
|
@k8s-bot test this issue: #IGNORE |
|
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
|
GCE e2e build/test failed for commit 04a5854. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
|
@bgrant0607 Brian, are you able to see whether the jenkins e2e failure is related specifically to this PR? Nothing is obvious to me from the log. It had passed previously (before I made the label change in the daemonset yaml), but it seems unlikely that the daemonset change would be implicated. |
|
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
|
GCE e2e build/test passed for commit 04a5854. |
|
GCE e2e build/test passed for commit 04a5854. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 04a5854. |
|
@amygdala In the future, please ping me by IM |
|
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
|
GCE e2e build/test passed for commit 04a5854. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 04a5854. |
|
Merging in hopes of fixing the cassandra e2e. The submit queue is blocked by #22611. |
Cassandra example: daemonset volume fix, readme cleanup, update to new gcr image
Cassandra example: daemonset volume fix, readme cleanup, update to new gcr image consistent with the code base.
Am thinking to split the changes to this example into two phases. In this PR:
google-samplescassandra-daemonset.yaml(didn't work before; works now)Then in a second phase, we can:
cc @bgrant0607