Fix broken cassandra test: Up to date containers + RC of 2 nodes with… #21639
Conversation
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
jayunit100
force-pushed
the
cassandra-example-fix
branch
from
cb2136b to
23a3a61
Compare
|
GCE e2e build/test failed for commit cb2136be101132490cb712ebb42a49010b72ca01. |
|
GCE e2e test build/test passed for commit 23a3a61bdf9ccbe1c8fd0acef4772cb641b78dd9. |
|
FYI one of the commits here is an updated jar file. That jar file simply builds the latest containers which have the correct internal endpoint |
jayunit100
force-pushed
the
cassandra-example-fix
branch
from
23a3a61 to
bc18bda
Compare
|
PTAL @brendandburns @davidopp |
|
GCE e2e test build/test passed for commit bc18bdaf5080b211ed644bfd577c2d70dd188c6c. |
|
@jayunit100 I'd rather rebuild myself. Can you split the PR so that we can merge the updated jar and then I can rebuild the image and push to gcr? |
|
Sure.
|
jayunit100
force-pushed
the
cassandra-example-fix
branch
2 times, most recently
from
236d9c1 to
9e1911c
Compare
|
Ok @brendandburns i think this is what you meant. look forward to your follow on Jar fix ! thanks ! |
|
GCE e2e test build/test passed for commit 236d9c18597f1f13b26f24ea8a82e66fb3851a0d. |
|
GCE e2e test build/test passed for commit 9e1911c5b863e146fb9694074cc5dcaeda84a39f. |
jayunit100
force-pushed
the
cassandra-example-fix
branch
from
9e1911c to
4c91cf2
Compare
|
GCE e2e test build/test passed for commit 4c91cf2. |
|
bump @brendandburns |
brendandburns
added
the
lgtm
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
@ihmcreery ok here we go, this should go in soon to I guess... That is about half the flakes in examples that should now be addressed. We can sync on the others next Tuesday in sig-testing I guess . Thanks Brendan for the review! Please let us know when the containers are updated as well! |
|
GCE e2e test build/test passed for commit 4c91cf2. |
|
ping @lhmcreely maybe we can merge this so we can do another evaluate of the examples/ e2es by this wknd to see what work is left |
| err = waitForEndpoint(c, ns, "cassandra") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| By("create and scale rc") | ||
| // Create an RC with n nodes in it. Each node will then be verified. |
There was a problem hiding this comment.
"with n nodes in it" isn't a particularly helpful comment since the n isn't defined in this file...
There was a problem hiding this comment.
it is only meaningful in context of the diff, because we don't (create, scale to n, verify), but rather (create n, verify). agree its not super useful, it's at best redundant since this can be seen from the code .
|
Oh never mind my comment, I see it has been LGTMd already |
Fix broken cassandra test: Up to date containers + RC of 2 nodes with…
|
cc @amygdala |
|
See also #21645 |
…out rescaling. Update cassandra jar in container build, fixes another portion of #20999