-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump container-vm in 1.2 to container-v1-2-v20160218 #21514
Bump container-vm in 1.2 to container-v1-2-v20160218 #21514
Conversation
Finally we are having prerelease image for testing now! Thanks! LGTM @kubernetes/goog-node |
Labelling this PR as size/S |
GCE e2e test build/test passed for commit 7f94e3e. |
@pwittrock Can we have this pr merged manually? I want to kick out the tests against docker 1.9.1 without upgrade through salt as soon as possible, so that I can make the final decision on which docker version to go with 1.2 release. To make the final decision, I need to:
This is the last bit I want to check. Meanwhile I want to kick out another round soaking tests with #21326 which resolves #20096. Since both have the same symptoms, I want to them to run through separate build. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit 7f94e3e. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
pr needs a rebase |
@pwittrock: Er, not this one? |
yeah, not this one; and e2e tests are passed twice above, even one for merge-bot :-( |
@zmerlynn Yeah, it failed when I tried to merge so I thought that was the issue |
GCE e2e build/test failed for commit 7f94e3e. |
Guess the merge failed for some other reason though |
@pwittrock: I've seen the merge button fail if it races with merges on another PR (like maybe from the submit queue), or it might've been a status update to this PR, etc. It can be twitchy. |
GCE e2e build/test failed for commit 7f94e3e. |
GCE e2e test build/test passed for commit 7f94e3e. |
Bump container-vm in 1.2 to container-v1-2-v20160218
Every time any PR merges github recalculates the mergeability of every single other PR, and the button greys out while it recalculates. We see it all the time in the merge robot, when it happens the bot just sleeps for 2 seconds and asks github if it is mergeable a second time. |
This is a prerelease
container-vm
image with Docker 1.9.1.