Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump container-vm in 1.2 to container-v1-2-v20160218 #21514

Merged
merged 2 commits into from
Feb 19, 2016

Conversation

zmerlynn
Copy link
Member

This is a prerelease container-vm image with Docker 1.9.1.

@dchen1107
Copy link
Member

Finally we are having prerelease image for testing now! Thanks!

LGTM

@kubernetes/goog-node

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2016
@dchen1107 dchen1107 added this to the v1.2 milestone Feb 18, 2016
@dchen1107 dchen1107 added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 18, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2016
@dchen1107
Copy link
Member

#21086

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit 7f94e3e.

@eparis eparis added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 18, 2016
@dchen1107
Copy link
Member

@pwittrock Can we have this pr merged manually? I want to kick out the tests against docker 1.9.1 without upgrade through salt as soon as possible, so that I can make the final decision on which docker version to go with 1.2 release. To make the final decision, I need to:

  1. rule out the docker checkpoint files corruption issue completely. See Docker 1.9 doesn't restart cleanly #20995 for detail.
  2. rule out docker 1.9.X performance downgrade issue: see e2e flake: tests are failing on "All nodes should be ready" condition #21261 for detail

This is the last bit I want to check. Meanwhile I want to kick out another round soaking tests with #21326 which resolves #20096. Since both have the same symptoms, I want to them to run through separate build.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit 7f94e3e.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@pwittrock
Copy link
Member

pr needs a rebase

@zmerlynn
Copy link
Member Author

@pwittrock: Er, not this one?

@dchen1107
Copy link
Member

yeah, not this one; and e2e tests are passed twice above, even one for merge-bot :-(

@pwittrock
Copy link
Member

@zmerlynn Yeah, it failed when I tried to merge so I thought that was the issue

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e build/test failed for commit 7f94e3e.

@pwittrock
Copy link
Member

@k8s-bot test this issue: #21467

@pwittrock
Copy link
Member

Guess the merge failed for some other reason though

@zmerlynn
Copy link
Member Author

@pwittrock: I've seen the merge button fail if it races with merges on another PR (like maybe from the submit queue), or it might've been a status update to this PR, etc. It can be twitchy.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e build/test failed for commit 7f94e3e.

@pwittrock
Copy link
Member

@k8s-bot test this issue: #21522

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit 7f94e3e.

pwittrock pushed a commit that referenced this pull request Feb 19, 2016
Bump container-vm in 1.2 to container-v1-2-v20160218
@pwittrock pwittrock merged commit 8b05b15 into kubernetes:master Feb 19, 2016
@zmerlynn zmerlynn deleted the container-v1-2-v20160218 branch February 19, 2016 03:17
@eparis
Copy link
Contributor

eparis commented Feb 19, 2016

Every time any PR merges github recalculates the mergeability of every single other PR, and the button greys out while it recalculates. We see it all the time in the merge robot, when it happens the bot just sleeps for 2 seconds and asks github if it is mergeable a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants