Fixes #1612 kubelet should fail to start if it cannot create rootDir #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsurprisingly this broke tests that don't run as root. Can you fix up the failing tests to pass root=/tmp/kubelet.$$ or something? |
|
Can you squash your commits into one? |
erikstmartin
force-pushed
the
kubelet-rootdir-fix
branch
from
de96800 to
f75f2bb
Compare
|
Done. I was itching to do that but I didn't know if you wanted all the commits as part of the commentary in the issue. |
|
I couldn't find you from our internal cla database using your github id: erikstmartin. Which id are you using? Or do you have a company? |
|
I haven't submitted a CLA directly for k8s, I do have one for golang though, i'm assuming it's under my email address alakriti@gmail.com |
|
Found CLA under that email address. Thanks. |
dchen1107
added a commit
that referenced
this pull request
Nov 3, 2014
Fixes #1612 kubelet should fail to start if it cannot create rootDir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the ticket, kubelet will fail to start if it cannot create the rootDir.
I have a golang CLA if that will work for k8s as well.