Use user-string in authentication attributes. #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictune
force-pushed
the
get_user_attrib
branch
2 times, most recently
from
41336c4 to
6372d62
Compare
| } | ||
|
|
||
| // TestUnknownUserIsUnauthorized tests that a user who is unknown | ||
| // to the authentication system get status code "Unauthoried". |
There was a problem hiding this comment.
fixed. Will rebase when #2116 in.
|
Needs a rebase and tests are failing. |
erictune
force-pushed
the
get_user_attrib
branch
from
cf45f22 to
71162c2
Compare
|
Rebased, which is expected to fix test failure. |
|
Will need rebase due to #2124 and adjustment to avoid test failure. Don't merge yet. |
erictune
force-pushed
the
get_user_attrib
branch
from
71162c2 to
665ca32
Compare
|
PTAL |
| @@ -24,6 +24,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/auth/authorizer" | |||
| auth_handlers "github.com/GoogleCloudPlatform/kubernetes/pkg/auth/handlers" | |||
erictune
force-pushed
the
get_user_attrib
branch
2 times, most recently
from
ce06bb9 to
ba5ba28
Compare
|
rebased, and fixed review comment, |
erictune
force-pushed
the
get_user_attrib
branch
from
ba5ba28 to
a88f070
Compare
|
trying to repro the failure locally. |
erictune
force-pushed
the
get_user_attrib
branch
2 times, most recently
from
c86c1be to
4d058dc
Compare
|
Fixed failures via #2142 |
Added integration tests for user-based auth.
erictune
force-pushed
the
get_user_attrib
branch
from
4d058dc to
3045035
Compare
|
PTAL |
|
LGTM |
dchen1107
added a commit
that referenced
this pull request
Nov 4, 2014
Use user-string in authentication attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes under review in PR #2116