implement kubectl get/describe for ReplicaSet #20886
Conversation
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
GCE e2e test build/test passed for commit 4935b804413967c49d7c43f0b7ef72addbf31f18. |
mqliang
force-pushed
the
ReplicaSet-kubectl
branch
from
4935b80 to
b5e99be
Compare
|
Thanks! |
| @@ -475,10 +468,6 @@ func describePod(pod *api.Pod, rcs []api.ReplicationController, events *api.Even | |||
| fmt.Fprintf(out, "Reason:\t%s\n", pod.Status.Reason) | |||
| fmt.Fprintf(out, "Message:\t%s\n", pod.Status.Message) | |||
| fmt.Fprintf(out, "IP:\t%s\n", pod.Status.PodIP) | |||
| var matchingRCs []*api.ReplicationController | |||
|
GCE e2e test build/test passed for commit b5e99be. |
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
cc @kubernetes/kubectl |
| @@ -87,6 +87,7 @@ func describerMap(c *client.Client) map[unversioned.GroupKind]Describer { | |||
| api.Kind("Endpoints"): &EndpointsDescriber{c}, | |||
| api.Kind("ConfigMap"): &ConfigMapDescriber{c}, | |||
|
|
|||
| extensions.Kind("ReplicaSet"): &ReplicaSetDescriber{c}, | |||
There was a problem hiding this comment.
@smarterclayton @nikhiljindal DefaultObjectDescriber (below) was added by PR #4880.
DefaultObjectDescriber only supports a small subset of resource types. I can't see it used anywhere other than the DefaultObjectDescriber unit test. I checked Openshift Origin also.
That PR was about enabling printing of local objects. I don't see how DefaultObjectDescriber is related to that. Can we rip it out?
|
Thanks. This looks like a faithful translation of the RC code. I had a suggestion and a question, but this is good enough to start with. We can make additional changes in subsequent PRs. |
|
LGTM |
bgrant0607
added
the
lgtm
|
Tests can be added in a subsequent PR, also. |
|
See also #20928 |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit b5e99be. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
| func FormatLabelSelector(labelSelector *LabelSelector) string { | ||
| var l string | ||
| if selector, err := LabelSelectorAsSelector(labelSelector); err != nil { | ||
| l = selector.String() |
Ref #3024