WIP: add kubernetes_nginx to contrib/ #2079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a generic nginx service running via docker to be loaded on a k8s master node. See README.md for more details.
| @@ -0,0 +1,17 @@ | |||
| FROM debian:wheezy | |||
There was a problem hiding this comment.
nit: we tend to use google/debian:wheezy, it's just like wheezy, but includes some tools that work great on GCE. Not a requirement, but a nice-to-have.
There was a problem hiding this comment.
Easy enough change
|
I've been out of the loop for a while. Is this still something we want to try to do? If so, I'll look at the latest and the kubernetes-ro stuff to see if it helps solve the problems. |
|
Can one of the admins verify this patch? |
haircommander
pushed a commit
to haircommander/kubernetes
that referenced
this pull request
Sep 12, 2024
…alth-checker-retry NO-JIRA: UPSTREAM: <carry>: retrying etcd Unavailable errors for the etcd health and ready checkers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for comments on a path forward.
This is a small addition to contrib/ that will hold the standard k8s nginx service which proxies to the apiserver. This is a step towards dockerizing all the various services (#19).
Currently this image relies on a host volume which is requires to have the SSL certificates and htpasswd files in the correct locations. Leveraging host volumes has the following benefits:
The primary downside is the fact that we have to manage files on the host which must be in place prior to the container starting.
Thoughts?