move columns into wide option to make result more readable #20557

adohe-zz · 2016-02-03T15:47:43Z

Fixes #19775

k8s-bot · 2016-02-03T15:48:12Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-02-03T15:49:13Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot · 2016-02-03T15:56:45Z

PR needs rebase

k8s-github-robot · 2016-02-03T15:56:45Z

Labelling this PR as size/L

bgrant0607 · 2016-02-03T16:38:55Z

cc @erictune @Kargakis

bgrant0607 · 2016-02-03T16:39:01Z

cc @janetkuo

bgrant0607 · 2016-02-03T16:42:30Z

pkg/kubectl/resource_printer.go

-var replicationControllerColumns = []string{"CONTROLLER", "CONTAINER(S)", "IMAGE(S)", "SELECTOR", "REPLICAS", "AGE"}
-var jobColumns = []string{"JOB", "CONTAINER(S)", "IMAGE(S)", "SELECTOR", "SUCCESSFUL"}
-var serviceColumns = []string{"NAME", "CLUSTER_IP", "EXTERNAL_IP", "PORT(S)", "SELECTOR", "AGE"}
+var replicationControllerColumns = []string{"CONTROLLER", "REPLICAS", "AGE"}


Please rebase. Deployment columns are now:

var deploymentColumns = []string{"NAME", "DESIRED", "CURRENT", "UP-TO-DATE", "AVAILABLE", "AGE"}

As suggested by @Kargakis, please display DESIRED and CURRENT rather than just REPLICAS for ReplicationController.

It could be done in a separate PR, but DESIRED and CURRENT would be nice to have for DaemonSet also.

Ok, I will open a separate PR to add DESIRED and CURRENT to ReplicationController and DaemonSet as soon as possible.

@bgrant0607 I will open a separate PR to add DESIRED and CURRENT to ReplicationController and DaemonSet later.

adohe-zz · 2016-02-04T04:14:45Z

Ok, I will do it now

0xmichalis · 2016-02-04T10:26:45Z

pkg/kubectl/resource_printer.go

-var replicationControllerColumns = []string{"CONTROLLER", "CONTAINER(S)", "IMAGE(S)", "SELECTOR", "REPLICAS", "AGE"}
-var jobColumns = []string{"JOB", "CONTAINER(S)", "IMAGE(S)", "SELECTOR", "SUCCESSFUL"}
-var serviceColumns = []string{"NAME", "CLUSTER-IP", "EXTERNAL-IP", "PORT(S)", "SELECTOR", "AGE"}
+var replicationControllerColumns = []string{"CONTROLLER", "REPLICAS", "AGE"}


While on this, can you rename REPLICAS to DESIRED and add CURRENT to show rc.status.replicas?

cc: @bgrant0607

We do want that change, but a separate PR is fine.

k8s-github-robot · 2016-02-04T15:05:49Z

@bgrant0607
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

k8s-github-robot · 2016-02-04T15:05:49Z

@bgrant0607
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

k8s-bot · 2016-02-04T15:17:24Z

GCE e2e build/test failed for commit 8bb7b3db1320466997f8a8f4753e95dc3dc8b100.

adohe-zz · 2016-02-04T16:01:38Z

For log, this case failed:

FAIL    k8s.io/kubernetes/pkg/client/unversioned/remotecommand  300.059s

k8s-bot · 2016-02-04T19:31:40Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

bgrant0607 · 2016-02-06T07:27:24Z

add to whitelist

bgrant0607 · 2016-02-06T07:27:52Z

@adohe Please rebase. We'll try to get this merged.

k8s-bot · 2016-02-06T07:57:13Z

GCE e2e test build/test passed for commit 8bb7b3db1320466997f8a8f4753e95dc3dc8b100.

bgrant0607 · 2016-02-09T06:16:57Z

If #20886 merges first, we'll want to make the same change to ReplicaSet. Or, if this merges first, we'll update #20886.

cc @mqliang @madhusudancs

adohe-zz · 2016-02-09T06:23:26Z

it's ok to update the ReplicaSet but I am afraid I have to update this three days later since I am on the new year holiday

bgrant0607 · 2016-02-10T21:10:10Z

ReplicaSet has merged.

adohe-zz · 2016-02-11T00:59:54Z

@bgrant0607 I am still on the holiday and will update this the day after tomorrow sorry about the late.

bgrant0607 · 2016-02-11T01:16:27Z

@adohe No problem. I was just letting you know.

k8s-bot · 2016-02-14T09:23:54Z

GCE e2e test build/test passed for commit 53d4b15.

bgrant0607 · 2016-02-14T17:19:31Z

LGTM, thanks!

k8s-github-robot · 2016-02-14T17:54:00Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-02-14T18:21:27Z

GCE e2e test build/test passed for commit 53d4b15.

adohe-zz · 2016-02-15T03:27:32Z

@bgrant0607 the Jenkins unit/integration just failed. I checked the build-log.txt, and just found hack/test-go.sh failed, but can't get more detailed info. So I rebase and re-run hack/test-go.sh on my CentOS(actually I did run hack/test-go.sh before I push to github), and just found this two errors:

--- FAIL: Test_ExternalID (0.17s)
    mesos_test.go:274: ExternalID should not be able to resolve "mesos3.internal.company.com"
FAIL
FAIL    k8s.io/kubernetes/pkg/cloudprovider/providers/mesos 0.185s

--- FAIL: TestReadConfigData (0.09s)
    helpers_test.go:266: unexpected non-error for http://some.non.existent.foobar
FAIL
FAIL    k8s.io/kubernetes/pkg/kubectl/cmd/util  0.185s

This just blocks this PR get merged.

bgrant0607 · 2016-02-15T06:19:56Z

@k8s-bot test this issue: #18708

@adohe The unit test failure on jenkins was caused by a flaky test. I just restarted it.

I haven't seen the test failures you posted before. It looks like DNS is resolving names it shouldn't?

k8s-bot · 2016-02-15T06:44:34Z

GCE e2e test build/test passed for commit 53d4b15.

adohe-zz · 2016-02-15T06:58:41Z

@bgrant0607 yes, I just re-run the unit tests. First I ran hack/test-go.sh under network off, the unit tests will success. Then I ran hack/test-go.sh with network on, I just got an error, some test cases failed:

--- FAIL: Test_ExternalID (0.11s)
    mesos_test.go:274: ExternalID should not be able to resolve "mesos3.internal.company.com"
FAIL
FAIL    k8s.io/kubernetes/pkg/cloudprovider/providers/mesos 0.133s

--- FAIL: TestReadConfigData (0.14s)
    helpers_test.go:266: unexpected non-error for http://some.non.existent.foobar
FAIL
FAIL    k8s.io/kubernetes/pkg/kubectl/cmd/util  0.261s

I think both of these are related with DNS.

k8s-github-robot · 2016-02-15T07:49:56Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-02-15T08:18:07Z

GCE e2e test build/test passed for commit 53d4b15.

k8s-github-robot · 2016-02-15T08:18:37Z

Automatic merge from submit-queue

Auto commit by PR queue bot

googlebot added the cla: yes label Feb 3, 2016

adohe-zz mentioned this pull request Feb 3, 2016

Move "Containers" and "Images" out of kubectl get rc and into -o wide #19775

Closed

k8s-github-robot assigned deads2k Feb 3, 2016

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2016

bgrant0607 reviewed Feb 3, 2016
View reviewed changes

adohe-zz force-pushed the kubectl_update_wide branch from ddac553 to 0377f4f Compare February 4, 2016 04:37

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2016

adohe-zz force-pushed the kubectl_update_wide branch from 034b786 to 8bb7b3d Compare February 4, 2016 06:14

0xmichalis reviewed Feb 4, 2016
View reviewed changes

bgrant0607 closed this Feb 4, 2016

bgrant0607 reopened this Feb 4, 2016

bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Feb 4, 2016

bgrant0607 assigned 0xmichalis and unassigned deads2k Feb 4, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2016

bgrant0607 mentioned this pull request Feb 10, 2016

Make kubectl describers and resource printers more consistent #20941

Closed

janetkuo mentioned this pull request Feb 11, 2016

Fix selector output when get/describe replicasets #20994

Merged

bgrant0607 added this to the v1.2 milestone Feb 12, 2016

move columns into wide option to make result more readable

53d4b15

adohe-zz force-pushed the kubectl_update_wide branch from 8bb7b3d to 53d4b15 Compare February 14, 2016 08:56

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2016

bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 14, 2016

k8s-github-robot pushed a commit that referenced this pull request Feb 15, 2016

Merge pull request #20557 from AdoHe/kubectl_update_wide

94b3c95

Auto commit by PR queue bot

k8s-github-robot merged commit 94b3c95 into kubernetes:master Feb 15, 2016

adohe-zz deleted the kubectl_update_wide branch February 17, 2016 13:23

move columns into wide option to make result more readable #20557

move columns into wide option to make result more readable #20557

Conversation

adohe-zz commented Feb 3, 2016

k8s-bot commented Feb 3, 2016

k8s-bot commented Feb 3, 2016

k8s-github-robot commented Feb 3, 2016

k8s-github-robot commented Feb 3, 2016

bgrant0607 commented Feb 3, 2016

bgrant0607 commented Feb 3, 2016

bgrant0607 Feb 3, 2016

Choose a reason for hiding this comment

bgrant0607 Feb 3, 2016

Choose a reason for hiding this comment

adohe-zz Feb 4, 2016

Choose a reason for hiding this comment

adohe-zz Feb 14, 2016

Choose a reason for hiding this comment

adohe-zz commented Feb 4, 2016

0xmichalis Feb 4, 2016

Choose a reason for hiding this comment

bgrant0607 Feb 4, 2016

Choose a reason for hiding this comment

k8s-github-robot commented Feb 4, 2016

k8s-github-robot commented Feb 4, 2016

k8s-bot commented Feb 4, 2016

adohe-zz commented Feb 4, 2016

k8s-bot commented Feb 4, 2016

bgrant0607 commented Feb 6, 2016

bgrant0607 commented Feb 6, 2016

k8s-bot commented Feb 6, 2016

bgrant0607 commented Feb 9, 2016

adohe-zz commented Feb 9, 2016

bgrant0607 commented Feb 10, 2016

adohe-zz commented Feb 11, 2016

bgrant0607 commented Feb 11, 2016

k8s-bot commented Feb 14, 2016

bgrant0607 commented Feb 14, 2016

k8s-github-robot commented Feb 14, 2016

k8s-bot commented Feb 14, 2016

adohe-zz commented Feb 15, 2016

bgrant0607 commented Feb 15, 2016

k8s-bot commented Feb 15, 2016

adohe-zz commented Feb 15, 2016

k8s-github-robot commented Feb 15, 2016

k8s-bot commented Feb 15, 2016

k8s-github-robot commented Feb 15, 2016