Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deployments by default #20517

Merged
merged 3 commits into from
Feb 12, 2016
Merged

Enable deployments by default #20517

merged 3 commits into from
Feb 12, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Feb 2, 2016

Enable deployments by default, enable deployments in kubectl run, and update related docs/scripts.

Addresses #15313

cc @bgrant0607 @nikhiljindal @ironcladlou @Kargakis @kubernetes/sig-config @kubernetes/kubectl @madhusudancs

@janetkuo janetkuo added this to the v1.2 milestone Feb 2, 2016
@janetkuo janetkuo changed the title Enable deployments default Enable deployments by default Feb 2, 2016
@janetkuo janetkuo mentioned this pull request Feb 2, 2016
Closed
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2016
@janetkuo janetkuo force-pushed the enable-deployments-default branch from eaf7a3c to 21d7274 Compare February 2, 2016 22:21
@bgrant0607
Copy link
Member

LGTM, but waiting on #20389 and the rename of uniqueLabelKey before merging.

@janetkuo janetkuo changed the title Enable deployments by default Enable deployments by default [LGTM] Feb 2, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 2, 2016

GCE e2e build/test failed for commit eaf7a3cd1a588afba0c0f12bd4401cb29bc3ef1f.

@janetkuo
Copy link
Member Author

janetkuo commented Feb 2, 2016

e2e test failed because a test assumes kubectl run generates rc by default. Modified the test for rc and added another test for deployment.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 2, 2016

GCE e2e build/test failed for commit 21d7274a0dfdd8c585dd705f81568831bd2d56a2.

@janetkuo janetkuo force-pushed the enable-deployments-default branch from 7987551 to 07b07f1 Compare February 2, 2016 23:34
@k8s-github-robot k8s-github-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 2, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 2, 2016

GCE e2e build/test failed for commit 7987551a79970f667729b5bc272d4fd8fa39c593.

@k8s-bot
Copy link

k8s-bot commented Feb 3, 2016

GCE e2e test build/test passed for commit 07b07f1a3584ea374f1c358d98995a85af9efdfb.

@janetkuo janetkuo force-pushed the enable-deployments-default branch from 07b07f1 to e92fce5 Compare February 3, 2016 00:44
@k8s-bot
Copy link

k8s-bot commented Feb 3, 2016

GCE e2e test build/test passed for commit e92fce5fd469911161656ca41362b1aaaa1edda2.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2016
@janetkuo janetkuo force-pushed the enable-deployments-default branch from 646e7ba to 55e5a78 Compare February 10, 2016 18:43
@janetkuo janetkuo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 10, 2016

GCE e2e test build/test passed for commit 55e5a7814c76a1f33e28a9fba963cb638e8ee88a.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2016
@k8s-github-robot
Copy link

PR needs rebase

@madhusudancs madhusudancs mentioned this pull request Feb 12, 2016
Merged
@bgrant0607
Copy link
Member

Please rebase. I think we can enable Deployment now.

cc @madhusudancs

@madhusudancs madhusudancs mentioned this pull request Feb 12, 2016
Closed
@janetkuo janetkuo force-pushed the enable-deployments-default branch from 55e5a78 to 4e8b487 Compare February 12, 2016 20:30
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2016
@janetkuo janetkuo added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 12, 2016
@janetkuo
Copy link
Member Author

@bgrant0607 rebased.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2016
@bgrant0607
Copy link
Member

LGTM

@janetkuo janetkuo changed the title Enable deployments by default [LGTM] Enable deployments by default Feb 12, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 12, 2016

GCE e2e test build/test passed for commit 4e8b487.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 12, 2016

GCE e2e test build/test passed for commit 4e8b487.

@jdef jdef mentioned this pull request Feb 12, 2016
Open
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 12, 2016

GCE e2e test build/test passed for commit 4e8b487.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 12, 2016
Merge pull request #20517 from janetkuo/enable-deployments-default
8a4a73e 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 8a4a73e into kubernetes:master Feb 12, 2016
@ghodss
Copy link
Contributor

ghodss commented Feb 13, 2016

🎆

@janetkuo janetkuo added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
area/app-lifecycle lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@janetkuo @k8s-github-robot @bgrant0607 @k8s-bot @ghodss @k8s-teamcity-mesosphere @googlebot @brendandburns