Revert "resolve the bug when cluster CIDR is not /8" #20144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
Actually please ignore this; I wasn't able to revert #17754 from the UI for some reason, so I'll send out a PR manually reverting both PRs. |
|
Oh, looks like revert didn't work for #17754 because that PR was before controller/ directory was split up... And I definitely don't want to revert the PR that split up the directory... So I'll just do the manual revert as I said. |
|
GCE e2e test build/test passed for commit 5d0d292. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19580
ref//#20048
@cjcullen @ArtfulCoder