Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'k8s' prefix to docker containers that we manage #200

Merged
merged 1 commit into from
Jun 21, 2014

Conversation

jjhuff
Copy link
Contributor

@jjhuff jjhuff commented Jun 21, 2014

Previously, the logic of looking for a '--' seemed a little fragile.

@lavalamp
Copy link
Member

I agree that the -- logic is a terrible hack. To solve it for real, though, I was thinking we should just make unique names and keep track of what names we've used, rather than parsing the names for our pattern. I'm OK with this patch in the interim, though.

lavalamp added a commit that referenced this pull request Jun 21, 2014
Add a 'k8s' prefix to docker containers that we manage
@lavalamp lavalamp merged commit dc35a98 into kubernetes:master Jun 21, 2014
@jjhuff
Copy link
Contributor Author

jjhuff commented Jun 21, 2014

Yeah.
Does docker allow us to attach arbitrary data to a container's info? Or maybe go with nested containers? Although, that'd probably mean that any managed containers would die if the kubelet died, I'm not sure how I feel about that...

@lavalamp
Copy link
Member

Yeah, the kubelet would have to store the mapping persistently, or possibly apiserver can pre-generate globally unique ids for this purpose (a la #199). It's a requirement that containers keep running even if kubelet restarts, so any subcontainer design would have to take that into account.

@jjhuff
Copy link
Contributor Author

jjhuff commented Jun 21, 2014

Cool. #199 looks like the ticket.

On Sat, Jun 21, 2014 at 2:05 PM, Daniel Smith notifications@github.com
wrote:

Yeah, the kubelet would have to store the mapping persistently, or
possibly apiserver can pre-generate globally unique ids for this purpose (a
la #199 #199).
It's a requirement that containers keep running even if kubelet restarts,
so any subcontainer design would have to take that into account.


Reply to this email directly or view it on GitHub
#200 (comment)
.

@jjhuff jjhuff deleted the prefix_container branch June 21, 2014 21:23
rphillips added a commit to rphillips/kubernetes that referenced this pull request Mar 13, 2018
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
Release go signal for 10 March 2017
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
configmap and secret helper functions
pjh added a commit to pjh/kubernetes that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants