Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ReplicaSet client. #19746

Merged
merged 1 commit into from
Jan 29, 2016
Merged

Implement ReplicaSet client. #19746

merged 1 commit into from
Jan 29, 2016

Conversation

madhusudancs
Copy link
Contributor

No description provided.

@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 16, 2016

GCE e2e test build/test passed for commit 8d6b283f452f176d8334157e3209d03bd686fa89.

@madhusudancs madhusudancs force-pushed the replicaset-client branch 2 times, most recently from d0b74bc to c059137 Compare January 17, 2016 22:37
@k8s-bot
Copy link

k8s-bot commented Jan 17, 2016

GCE e2e test build/test passed for commit d0b74bc4ff4fb3df4c9ba081016a44bdeb3dbc84.

@k8s-bot
Copy link

k8s-bot commented Jan 17, 2016

GCE e2e test build/test passed for commit c059137f8cab753257db3d3af4d12ea5c39d0b97.

@k8s-bot
Copy link

k8s-bot commented Jan 18, 2016

GCE e2e test build/test passed for commit 35a0c960ef42228e51d5b9a898038bca3f1c1225.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 18, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 19, 2016

GCE e2e build/test failed for commit f95d5dc22bceb4200089c1bdd89cb930a83c172e.

@k8s-bot
Copy link

k8s-bot commented Jan 19, 2016

GCE e2e test build/test passed for commit 64d3361a15847998b95d2f9f6e1b919b2bb52cdf.

@k8s-bot
Copy link

k8s-bot commented Jan 19, 2016

GCE e2e test build/test passed for commit 6d27eff5c13f74f128f88b6ec98dc9fcbe33a448.

@k8s-bot
Copy link

k8s-bot commented Jan 19, 2016

GCE e2e test build/test passed for commit 8e1ec540e3fa1cfa30209d8177139a1d87143904.

@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 19, 2016

GCE e2e test build/test passed for commit 863d9bdf37620281a50f212a2b033bd2b9b58d42.

nikhiljindal
nikhiljindal reviewed Jan 19, 2016
View reviewed changes
pkg/client/unversioned/replica_sets.go
// List takes a selector, and returns the list of ReplicaSets that match that selector.
func (c *replicaSets) List(opts api.ListOptions) (result *extensions.ReplicaSetList, err error) {
result = &extensions.ReplicaSetList{}
err = c.client.Get().Namespace(c.ns).Resource("replicaSets").VersionedParams(&opts, api.Scheme).Do().Into(result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt the resource be "replicasets" (all lowercase)?

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2016
@madhusudancs
Copy link
Contributor Author

Adding LGTM back. Made some trivial comment changes based on @Kargakis' comments.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2016
@madhusudancs
Copy link
Contributor Author

@k8s-bot test this please.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit 62f7f061561089ace7430d6856b06a2043556230.

@madhusudancs
Copy link
Contributor Author

@k8s-bot test this please.

(Tests are failing for completely unrelated reasons.)

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit 62f7f061561089ace7430d6856b06a2043556230.

@k8s-bot
Copy link

k8s-bot commented Jan 26, 2016

GCE e2e test build/test passed for commit 62f7f061561089ace7430d6856b06a2043556230.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@bgrant0607
Copy link
Member

@k8s-oncall
This has been LGTM for over a week, has passed e2e a dozen times, and is blocking a dozen other PRs. Could we please get a manual merge since the submit queue is still broken?

@fabioy
Copy link
Contributor

fabioy commented Jan 28, 2016

I just merged a number of PRs to help with test (flakiness or investigations), so let me get one cycle of green runs. I'll manually merge this one afterwards.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2016
@fabioy
Copy link
Contributor

fabioy commented Jan 29, 2016

@madhusudancs Sorry, need another rebase. I can manually merge afterwards. Thanks.

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2016
@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2016
@madhusudancs
Copy link
Contributor Author

@fabioy Rebased. Please merge.

@k8s-bot
Copy link

k8s-bot commented Jan 29, 2016

GCE e2e test build/test passed for commit c25a0ce.

fabioy added a commit that referenced this pull request Jan 29, 2016
@fabioy
Merge pull request #19746 from madhusudancs/replicaset-client
e827c1c 
Implement ReplicaSet client.
@fabioy fabioy merged commit e827c1c into kubernetes:master Jan 29, 2016
@fabioy
Copy link
Contributor

fabioy commented Jan 29, 2016

Manually merged.

@madhusudancs madhusudancs mentioned this pull request Jan 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@madhusudancs @k8s-github-robot @k8s-bot @nikhiljindal @bgrant0607 @fabioy @k8s-teamcity-mesosphere @googlebot