Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fake handler using testing pkg #19685

Merged
merged 1 commit into from
Jan 16, 2016
Merged

Replace fake handler using testing pkg #19685

merged 1 commit into from
Jan 16, 2016

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Jan 15, 2016

Ref #15634

Use a testing pkg to replace testing util codes

@resouer
Replace to tag
98222b4 
Use a testing pkg to replace testing util codes
@resouer resouer changed the title Replace to tag Replace fake handler using testing pkg Jan 15, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 15, 2016

GCE e2e test build/test passed for commit 98222b4.

@resouer
Copy link
Contributor Author

resouer commented Jan 15, 2016

Just Another Minor Util Fix cc @thockin

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2016
@thockin thockin assigned thockin and unassigned caesarxuchao Jan 15, 2016
mikedanese added a commit that referenced this pull request Jan 16, 2016
@mikedanese
Merge pull request #19685 from resouer/testing
936c8cd 
Replace fake handler using testing pkg
@mikedanese mikedanese merged commit 936c8cd into kubernetes:master Jan 16, 2016
@resouer resouer deleted the testing branch January 21, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@resouer @k8s-github-robot @k8s-bot @k8s-teamcity-mesosphere @mikedanese @caesarxuchao @googlebot @thockin