Add support for kubectl create quota command #19625

maazkhan · 2016-01-13T23:59:30Z

Create a resource quota with the specified name.

Usage:
  kubectl create quota NAME [--hard=string] [flags]

Aliases:
  q

Examples:
  # Create a new resource quota named my-quota with specified hard limit
  $ kubectl create quota my-quota --hard=cpu=1,memory=1G,pods=2,services=3,replicationcontrollers=2,resourcequotas=1,secrets=5,persistentvolumeclaims=10

This change is

k8s-bot · 2016-01-14T00:00:16Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-01-14T00:01:12Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

derekwaynecarr · 2016-01-14T01:34:28Z

I will review this initially

ncdc · 2016-01-15T20:07:26Z

pkg/kubectl/cmd/create_quota.go

+// NewCmdCreateQuota is a macro command to create a new quota
+func NewCmdCreateQuota(f *cmdutil.Factory, cmdOut io.Writer) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:     "quota NAME [--hard=key1=value1,key2=value2] [--dry-run=bool]",


--hard is marked as a required flag below. We should remove the [brackets] around --hard, correct?

derekwaynecarr · 2016-01-15T20:51:16Z

I am evaluating how a quota can associate a resource to a particular workload-type (terminating vs always-running) and qos (best-effort vs burstable/guaranteed). Once I understand how that will look, I will review this PR, but please hold until that time. ETA is early next week.

derekwaynecarr · 2016-01-16T17:35:23Z

For your awareness, see: #19761

I do not anticipate what is presented here conflicting with what is shown.

Will do a deeper dive of this PR on Monday.

derekwaynecarr · 2016-01-19T17:51:00Z

pkg/kubectl/cmd/create_quota.go

+	cmdutil.AddApplyAnnotationFlags(cmd)
+	cmdutil.AddValidateFlags(cmd)
+	cmdutil.AddGeneratorFlags(cmd, cmdutil.ResourceQuotaV1GeneratorName)
+	cmd.Flags().String("hard", "", "Specify multiple key/value pair to insert in resourcequota (i.e. --hard=cpu=1,memory=1G,pods=2,services=3,replicationcontrollers=2,resourcequotas=1,secrets=5,persistentvolumeclaims=10)")


A comma-delimited set of resource=quantity pairs that define a hard limit.

k8s-bot · 2016-01-28T18:46:11Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2016-01-28T19:42:28Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

bgrant0607 · 2016-01-28T20:03:56Z

cc @kubernetes/kubectl

k8s-github-robot · 2016-02-04T04:20:19Z

PR needs rebase

k8s-bot · 2016-02-04T19:34:37Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

derekwaynecarr · 2016-02-29T19:42:32Z

@maazkhan - is this something you plan to pick up again?

maazkhan · 2016-03-01T19:26:42Z

@derekwaynecarr Sorry have been occupied with some other priority tasks at this point. I am not planning to pick this up for another 3-4 weeks.

k8s-bot · 2016-05-10T07:03:18Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-13T10:42:25Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-14T23:08:57Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-15T00:37:02Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

derekwaynecarr · 2016-06-15T01:44:26Z

If this is no longer on your agenda, I may pick this up soon because I
would find it useful day to day

On Tuesday, June 14, 2016, Kubernetes Bot notifications@github.com wrote:

Can one of the admins verify that this patch is reasonable to test? If so,
please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update
configurations in
kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull
https://github.com/kubernetes/test-infra/tree/master/jenkins/job-configs/kubernetes-jenkins-pull
instead.)

This message may repeat a few times in short succession due to
jenkinsci/ghprb-plugin#292
jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19625 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF8dbOlGkncq45muOyTgF5w3ZLipW95iks5qL0lNgaJpZM4HEfSR
.

k8s-bot · 2016-06-15T02:46:11Z

GCE e2e build/test failed for commit 21f1fc3.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

maazkhan · 2016-06-15T20:20:59Z

@derekwaynecarr Please go ahead with it. Thanks!

k8s-bot · 2016-06-23T22:10:26Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-29T12:04:24Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

ncdc · 2016-06-30T14:58:13Z

@derekwaynecarr I've asked @sttts to take a look at continuing this

sttts · 2016-07-01T12:59:24Z

Followed up by #28351

Automatic merge from submit-queue Add support for kubectl create quota command Follow-up of #19625 ``` Create a resourcequota with the specified name, hard limits and optional scopes Usage: kubectl create quota NAME [--hard=key1=value1,key2=value2] [--scopes=Scope1,Scope2] [--dry-run=bool] [flags] Aliases: quota, q Examples: // Create a new resourcequota named my-quota $ kubectl create quota my-quota --hard=cpu=1,memory=1G,pods=2,services=3,replicationcontrollers=2,resourcequotas=1,secrets=5,persistentvolumeclaims=10 // Create a new resourcequota named best-effort $ kubectl create quota best-effort --hard=pods=100 --scopes=BestEffort ```

UPSTREAM: 63339: kubelet: volume: do not create event on mount success Origin-commit: 0fc25b024cc543115495fbbfafed5c99b3ef0713

Add support for kubectl create quota command

21f1fc3

googlebot added the cla: yes label Jan 13, 2016

k8s-github-robot assigned janetkuo Jan 14, 2016

k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 14, 2016

derekwaynecarr assigned derekwaynecarr and unassigned janetkuo Jan 14, 2016

ncdc reviewed Jan 15, 2016
View reviewed changes

derekwaynecarr reviewed Jan 19, 2016
View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2016

k8s-github-robot added the kind/old-docs label Mar 1, 2016

k8s-github-robot added the release-note-label-needed label Mar 31, 2016

derekwaynecarr mentioned this pull request Jun 27, 2016

cluster quota to namespace mapping controller openshift/origin#9558

Merged

sttts self-assigned this Jun 30, 2016

sttts mentioned this pull request Jul 1, 2016

Add support for kubectl create quota command #28351

Merged

sttts closed this Jul 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for kubectl create quota command #19625

Add support for kubectl create quota command #19625

maazkhan commented Jan 13, 2016 •

edited by mikedanese

Loading

k8s-bot commented Jan 14, 2016

k8s-bot commented Jan 14, 2016

derekwaynecarr commented Jan 14, 2016

ncdc Jan 15, 2016

derekwaynecarr Jan 19, 2016

derekwaynecarr commented Jan 15, 2016

derekwaynecarr commented Jan 16, 2016

derekwaynecarr Jan 19, 2016

k8s-bot commented Jan 28, 2016

k8s-bot commented Jan 28, 2016

bgrant0607 commented Jan 28, 2016

k8s-github-robot commented Feb 4, 2016

k8s-bot commented Feb 4, 2016

derekwaynecarr commented Feb 29, 2016

maazkhan commented Mar 1, 2016

k8s-bot commented May 10, 2016

k8s-bot commented Jun 13, 2016

k8s-bot commented Jun 14, 2016

k8s-bot commented Jun 15, 2016

derekwaynecarr commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

maazkhan commented Jun 15, 2016

k8s-bot commented Jun 23, 2016

k8s-bot commented Jun 29, 2016

ncdc commented Jun 30, 2016

sttts commented Jul 1, 2016

Add support for kubectl create quota command #19625

Add support for kubectl create quota command #19625

Conversation

maazkhan commented Jan 13, 2016 • edited by mikedanese Loading

k8s-bot commented Jan 14, 2016

k8s-bot commented Jan 14, 2016

derekwaynecarr commented Jan 14, 2016

ncdc Jan 15, 2016

Choose a reason for hiding this comment

derekwaynecarr Jan 19, 2016

Choose a reason for hiding this comment

derekwaynecarr commented Jan 15, 2016

derekwaynecarr commented Jan 16, 2016

derekwaynecarr Jan 19, 2016

Choose a reason for hiding this comment

k8s-bot commented Jan 28, 2016

k8s-bot commented Jan 28, 2016

bgrant0607 commented Jan 28, 2016

k8s-github-robot commented Feb 4, 2016

k8s-bot commented Feb 4, 2016

derekwaynecarr commented Feb 29, 2016

maazkhan commented Mar 1, 2016

k8s-bot commented May 10, 2016

k8s-bot commented Jun 13, 2016

k8s-bot commented Jun 14, 2016

k8s-bot commented Jun 15, 2016

derekwaynecarr commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

maazkhan commented Jun 15, 2016

k8s-bot commented Jun 23, 2016

k8s-bot commented Jun 29, 2016

ncdc commented Jun 30, 2016

sttts commented Jul 1, 2016

maazkhan commented Jan 13, 2016 •

edited by mikedanese

Loading