Add support for applying set of resources via kubectl #1958

mfojtik · 2014-10-22T12:22:50Z

Discussion: #1905

mfojtik · 2014-10-22T12:22:57Z

This is a quick and dirty extraction from the origin repo where I removed references to our objects. Not sure if the Label update should be part of this or we can strip it down as well.

smarterclayton · 2014-10-22T13:04:13Z

Sorry, this was supposed to be on kubectl as a new submit command, not on kubecfg. Kubecfg is going away

smarterclayton · 2014-10-22T13:05:31Z

Take the label update out - this is about taking a set of files or a config or multiple configs directly as they are. Brian's comments on the other pull made a good case against addingn labels. If necessary we will move that back to templates

mfojtik · 2014-10-22T13:15:43Z

@smarterclayton OK, how about ClientMappings ? Without those I will have to guess the resource path from the Kind.

smarterclayton · 2014-10-22T17:15:33Z

abstract the mechanism to get the mappings for a given Kind into a method, only implement the Kube objects in that method, and then leave a TODO to sort out client extensibility.

mfojtik · 2014-10-22T18:10:52Z

@smarterclayton ack, will look into this tomorrow.

VojtechVitek · 2014-10-22T22:52:51Z

pkg/config/api/types.go

+
+// Config contains a set of Kubernetes resources to be applied.
+// TODO: Unify with Kubernetes Config
+//       https://github.com/GoogleCloudPlatform/kubernetes/pull/1007


Remove this TODO

bgrant0607 · 2014-10-23T03:24:55Z

@smarterclayton Which comments do you mean?

bgrant0607 · 2014-10-23T03:25:09Z

/cc @ghodss

bgrant0607 · 2014-10-23T03:27:24Z

pkg/config/api/v1beta1/types.go

+package v1beta1
+
+import (
+	kubeapi "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta1"


If we decide to keep this definition, we should spec a v1beta3 version, also.

bgrant0607 · 2014-10-23T04:40:52Z

Very cool! Thanks much.

soltysh · 2014-10-23T09:29:56Z

@mfojtik just a quick question, currently k8s has only single types.go and you're introducing the OpenShift model described in #1744, is it a step towards that cleanup, or you'll merge those into pkg/api/types.go?

smarterclayton · 2014-10-23T15:54:08Z

As per #1744 we may want to keep them separate and then import them into v1beta1/2/3/internal placeholders. Also, Config is not a server side type yet, even though it is an API type.

----- Original Message -----

@mfojtik just a quick question, currently k8s has only single types.go and
you're introducing the OpenShift model described in #1744, is it a step
towards that cleanup, or you'll merge those into pkg/api/types.go?

Reply to this email directly or view it on GitHub:
#1958 (comment)

mfojtik · 2014-10-24T16:27:58Z

@smarterclayton I updated the Config registration (moved it into api/*/types.go) and removed labels, etc. Can you please review those changes?

The kubectl is still pending, I will try to have some PoC this weekend.

bgrant0607 · 2014-10-24T16:58:19Z

pkg/config/config_test.json

+    {
+      "id": "frontend",
+      "kind": "Service",
+      "apiVersion": "v1beta3",


FYI, these aren't using the v1beta3 schema. It looks like v1beta1.

bgrant0607 · 2014-11-04T02:56:33Z

pkg/config/config.go

+// be valid API type. It requires ObjectTyper to parse the Version and Kind and
+// RESTMapper to get the resource URI and REST client that knows how to create
+// given type
+func ApplyItems(typer runtime.ObjectTyper, mapper meta.RESTMapper, clientFor ClientFunc, items []runtime.Object) errs.ValidationErrorList {


This just does Create. Please rename to CreateItems.

+1

How about CreateObjects ?

CreateObjects also SGTM, especially if "items" no longer exists in the serialization.

mfojtik · 2014-11-04T12:48:14Z

@bgrant0607 @smarterclayton PR rebased and updated. Thanks!

mfojtik · 2014-11-04T13:20:03Z

@smarterclayton @bgrant0607 I'm thinking about removing the config_test.json file or moving it into example... Also do we have some docs I should update about the kubectl createall command?

bgrant0607 · 2014-11-04T13:53:29Z

LGTM. Thanks!

config_test.json is useful, I think, because it illustrates the format expected by createall.

bgrant0607 · 2014-11-04T14:21:06Z

Regarding docs: we eventually need a new version of cli.md, but right now we don't have any doc for kubectl AFAIK.

Add support for applying set of resources via kubectl

smarterclayton · 2014-11-04T16:29:45Z

Some next steps I'd like to see - @bgrant0607 your opinion?

Define a generic mechanism for mapping input sources to a stream of runtime.Objects (including unknown types) (call this an Object stream)
- Includes directories, JSON files with arrays on disk, JSON files that are a standard List type, and JSON object streams (from HTTP / file etc)
- Integrate this into createall
- Ensure we have a good generic error reporting pattern
Determine whether we can simply move that function into create (just by relaxing our create arguments?) and remove create all
Should we also add that to kubectl update
- Determine whether kubectl update should have create-or-update behavior (make it an option?)
Allow listing of items from an Object stream

bgrant0607 · 2014-11-04T18:29:25Z

@smarterclayton SGTM. In addition to update and get, I'd like to be able to drive delete from an Object stream. Could you copy your last comment over to #1905?

Move KEP-5 to implementable

[release-4.14] OCPBUGS-14373: Fix flaky HPA e2e tests by not failing on context cancelled (kubernetes#117669)

mfojtik force-pushed the config branch from a504bfa to 8cea881 Compare October 22, 2014 12:36

VojtechVitek reviewed Oct 22, 2014
View reviewed changes

bgrant0607 self-assigned this Oct 23, 2014

bgrant0607 reviewed Oct 23, 2014
View reviewed changes

mfojtik force-pushed the config branch from 8cea881 to e0397a7 Compare October 24, 2014 16:25

bgrant0607 reviewed Oct 24, 2014
View reviewed changes

mfojtik force-pushed the config branch 2 times, most recently from 10e2ed7 to 6095e56 Compare October 27, 2014 13:11

mfojtik force-pushed the config branch from bf0df9f to 4b4f1db Compare November 3, 2014 12:36

mfojtik changed the title ~~[WIP] Add support for applying set of resources via kubectl~~ Add support for applying set of resources via kubectl Nov 3, 2014

bgrant0607 reviewed Nov 4, 2014
View reviewed changes

mfojtik force-pushed the config branch from 4b4f1db to 27a4689 Compare November 4, 2014 12:47

mfojtik force-pushed the config branch 2 times, most recently from bd47135 to 568173f Compare November 4, 2014 13:19

mfojtik force-pushed the config branch from 568173f to 27ce227 Compare November 4, 2014 13:50

Add support for creating a bulk of resources via kubectl apply

c8f88a3

mfojtik force-pushed the config branch from 27ce227 to c8f88a3 Compare November 4, 2014 13:52

bgrant0607 added a commit that referenced this pull request Nov 4, 2014

Merge pull request #1958 from mfojtik/config

e8dbcaf

Add support for applying set of resources via kubectl

bgrant0607 merged commit e8dbcaf into kubernetes:master Nov 4, 2014

mfojtik deleted the config branch November 4, 2014 14:49

smarterclayton mentioned this pull request Nov 4, 2014

Kubectl can apply config files in bulk #1905

Closed

ghodss mentioned this pull request Nov 6, 2014

Enable kubectl commands to take multiple objects #2215

Closed

This was referenced Nov 12, 2014

Kubectl create factory #2287

Merged

Add directory as option for createall command #2326

Merged

caesarxuchao mentioned this pull request Jun 16, 2015

remove pkg/config/config_test.json #9829

Merged

seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019

Merge pull request kubernetes#1958 from jbeda/kep-5-implementable

24aad1b

Move KEP-5 to implementable

tsmetana pushed a commit to tsmetana/kubernetes that referenced this pull request May 20, 2024

Merge pull request kubernetes#1958 from jkyros/fix-flaky-hpa-test

e709aa5

[release-4.14] OCPBUGS-14373: Fix flaky HPA e2e tests by not failing on context cancelled (kubernetes#117669)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for applying set of resources via kubectl #1958

Add support for applying set of resources via kubectl #1958

mfojtik commented Oct 22, 2014

mfojtik commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

mfojtik commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

mfojtik commented Oct 22, 2014

VojtechVitek Oct 22, 2014

bgrant0607 commented Oct 23, 2014

bgrant0607 commented Oct 23, 2014

bgrant0607 Oct 23, 2014

bgrant0607 commented Oct 23, 2014

soltysh commented Oct 23, 2014

smarterclayton commented Oct 23, 2014

mfojtik commented Oct 24, 2014

bgrant0607 Oct 24, 2014

bgrant0607 Nov 4, 2014

mfojtik Nov 4, 2014

bgrant0607 Nov 4, 2014

mfojtik commented Nov 4, 2014

mfojtik commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014

smarterclayton commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014

Add support for applying set of resources via kubectl #1958

Add support for applying set of resources via kubectl #1958

Conversation

mfojtik commented Oct 22, 2014

mfojtik commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

mfojtik commented Oct 22, 2014

smarterclayton commented Oct 22, 2014

mfojtik commented Oct 22, 2014

VojtechVitek Oct 22, 2014

Choose a reason for hiding this comment

bgrant0607 commented Oct 23, 2014

bgrant0607 commented Oct 23, 2014

bgrant0607 Oct 23, 2014

Choose a reason for hiding this comment

bgrant0607 commented Oct 23, 2014

soltysh commented Oct 23, 2014

smarterclayton commented Oct 23, 2014

mfojtik commented Oct 24, 2014

bgrant0607 Oct 24, 2014

Choose a reason for hiding this comment

bgrant0607 Nov 4, 2014

Choose a reason for hiding this comment

mfojtik Nov 4, 2014

Choose a reason for hiding this comment

bgrant0607 Nov 4, 2014

Choose a reason for hiding this comment

mfojtik commented Nov 4, 2014

mfojtik commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014

smarterclayton commented Nov 4, 2014

bgrant0607 commented Nov 4, 2014