-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track most remaining Jenkins E2E jobs. #19301
Conversation
Labelling this PR as size/M |
GCE e2e test build/test passed for commit 3619fb5a41314a410cad8feb29b139f3f1fc73b6. |
- project: | ||
name: kubernetes-e2e-1.1 | ||
trigger-job: 'kubernetes-build-1.1' | ||
test-owner: 'GKE on-call' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if maybe we should keep the GKE builds separate here? Having the GKE-specific text and then immediately overriding it for the gce- builds seems weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, fixed. I also had some of the descriptions wrong, that's fixed now too.
GCE e2e test build/test passed for commit 61ee06f14e03da35f6bf648caf20e3f6aaa391cc. |
Labelling this PR as size/L |
@ixdy made some changes, PTAL. Notably I made the emails send out to the proper places. @ihmccreery this is how to set emails recipients if you are using this format for your upgrade jobs. For yours you might as well just set the email to yourself in the template, instead of using a variable + global default, since you'll override it for every job anyway. |
GCE e2e test build/test passed for commit edc274b. |
LGTM |
Manual merge to watch Jenkins. |
Track most remaining Jenkins E2E jobs.
This leaves these e2e jobs untracked:
I noticed that the gke jobs email cloud-kubernetes-alerts@ as well as cloud-kubernetes-team@ . Is that necessary, or should I get rid of that?
gke-flaky exports these in its job config, which aren't necessary:
gce-release-1.0 exports this in its job config, unnecessary:
gce-disruptive-1.1 exports this in its job config, which should likely be included in release-1.1's e2e.sh case:
#18122. Please do not add LGTM tag. I'll merge manually to watch Jenkins. I did not backup these job configs.