-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write password in get-password #1915
Conversation
get-password overwrites the .kubernetes_auth, without respecting some added fields. For GCE, it is not necessary to write in the file in kube-up() because the file is written later in the function. In kube-push, it is not necessary to write since the cluster is already created. For vagrant, it was not saving them, so no change. Other providers are in the "icebox". Added todos to those.
LGTM |
1.3 passed and 1.2 failed with a timeout. Please kick travis? |
@@ -241,6 +241,8 @@ kube-up() { | |||
|
|||
detect-minions | |||
|
|||
# TODO: write .kubernetes_auth file with user/pass/certs/key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1832 is about to go in and we have to rationalize this.
At this point we could just delete But I'm not sure I understand the problem. When is this clobbering your password file? If the file is already there it shouldn't re-write it. It should only write it if it isn't there or the username/password can't be read. |
It is not fixing a bug. I am working on generating multiple passwords (at On Mon, Oct 20, 2014 at 4:28 PM, Joe Beda notifications@github.com wrote:
|
@erictune Gotcha! I'm not sure I'm totally cool with this change though. If something happens during the start up of the cluster and you Ctrl-C, there is a good chance that you'll have a cluster that you don't have the password for. We are carrying the password in memory for quite a while here. Is there some way we can write the password out ASAP if we generate it? If this is blocking you, we can get this in and I can clean things up after the rest of the flow becomes more obvious. One idea: How about we leverage |
@derekwaynecarr was going to look at namespace additions to kubectl, and one thing we'd like kubectl to manage would be the auth per namespace/server as well as other config. So you'd say ----- Original Message -----
|
@smarterclayton Why would you have another authentication token just because you are using a different namespace? You are still the same person. The authorizer should know what namespaces a user is authorized to use based on a policy file. When you say that kubectl is going to talk to multiple servers, are you talking about: |
I am working on PR for this afternoon that will add the basic kubectl namespace support that was in kubecfg. We can look at a follow-on PR for how we can do more server settings association that @smarterclayton discusses after iterating on an issue discussion when its a little clearer what we want. |
I don't think that have to be the same person - imagine this set of namespaces in a single cluster apiserver infrastructure: run by operations team for self-hosting Kube, log servers, proxies Admins want restricted access to infrastructure. They use an access token for infrastructure that has reduced privileges so that client compromise doesn't cause issues. Additionally, they may be logging in to A and B as different people to occasionally debug things. What I was mostly getting at is that the smallest unit of switching is namespace - you're unlikely to be two different people in the same namespace. You're slightly more likely to be using two different accounts on the same server, and almost certainly using two different accounts on two different servers. So scoping all of the client level config (server info, preferences, etc) to the namespace is valuable, but you're right, you're likely to share settings/config/auth across namespaces on the same server. I was just arguing for not forcing the client to require that auth be stored per server when you have the ability to quickly change namespaces and servers. ----- Original Message -----
|
Having the client remember what namespace you are in definitely makes sense. Thinking about github, I have:
|
…erry-pick-1892-to-release-4.15 [release-4.15] UPSTREAM: <carry>: OCPBUGS-31348: fix cpu manager cpuset check
get-password overwrites the .kubernetes_auth,
without respecting some added fields.
For GCE, it is not necessary to write in
the file in kube-up() because the file
is written later in the function.
In kube-push, it is not necessary to write
since the cluster is already created.
For vagrant, it was not saving them, so no change.
Other providers are in the "icebox". Added todos to those.