Update client-generator #18700
Merged
Update client-generator #18700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e build/test failed for commit d8f8fcdb95fcfd66b893d3ad93f1fbfa20528342. |
|
@k8s-bot e2e test this please |
|
GCE e2e test build/test passed for commit d8f8fcdb95fcfd66b893d3ad93f1fbfa20528342. |
| // DeleteCollection deletes a collection of objects. | ||
| func (c *$.type|privatePlural$) DeleteCollection(options *$.apiDeleteOptions|raw$, listOptions $.apiListOptions|raw$) error { | ||
| if options == nil { | ||
| return e.Client.Delete(). |
There was a problem hiding this comment.
Should be c.Client..., not e :)
|
A minor problem, otherwise lgtm. Feel free to apply the label after addressing the comment. Thank you. ref #18290 |
wojtek-t
force-pushed
the
fix_client_gen_script
branch
from
d8f8fcd to
4473abf
Compare
|
GCE e2e test build/test passed for commit 4473abf. |
|
@k8s-bot unit test this please |
|
@k8s-bot test this please |
|
GCE e2e test build/test passed for commit 4473abf. |
caesarxuchao
added
the
lgtm
|
LGTM. Thanks. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 4473abf. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 17, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.