Bind pods #1840
Merged
Bind pods #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used in subsequent PRs that add authorization.
|
all e2e tests pass except for services.sh on vagrant. |
Add --no-headers to kubectl get
Add forbidden error.
Add lock to fake handler to avoid races.
Added missing .sh extension
Fix dangerous Sprintf
Don't accept empty input in DecodeInto
There are three values that uniquely identify a pod on a host - the configuration source (etcd, file, http), the pod name, and the pod namespace. This change ensures that configuration properly makes those names unique by changing podFullName to contain both name (currently ID in v1beta1, Name in v1beta3) and namespace. The Kubelet does not properly handle information requests for pods not in the default namespace at this time.
Rename ManifestFactory -> BoundPodFactory and change the general structure of the call to focus on BoundPod.
|
Extracted from #1600 |
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Jan 5, 2024
OCPNODE-1892: Bump k8s api to 1.29.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1662 (extracted from #1600)
Minor conflict from Services v2 in
pkg/registry/pod/manifest_factory_test.go vs pkg/registry/pod/bound_pod_factory_test.go
If @smarterclayton shows up and does the rebase there, great, pull there. But this is going through e2e and will hit travis sooner this way...