Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

Labelling this PR as size/XS

Could you please remove the line of The fields "apiVersion" and "kind" are optional in version v1beta1 in exec.go since v1beta1 isn't supported?

Ok

Thanks.
The code looks okay to me, but I'm not familiar with this module, so that may not be worth a lot.

@feihujiang I found this little bug because I've developed a new k8s network plugin https://github.com/WIZARD-CXY/cxy-sdn and want use this piece of code.

Ref #16849

ping @thockin it's a very small change

This is a very small change, but it's not right, unfortunately. The network plugin API is not v1 yet.

Maybe it's better to recover the doc change #16849 ;-)

@thockin What's the // This struct represents version "v1" mean or just a wrong note?

That's a good point, and probably a bug in the comment.

@thockin Thanks, got it.

@WIZARD-CXY Would you like to open a new PR to recover the doc change and fix the bug in the comment.?

@thockin @feihujiang Then what version is the right version?

I think it is v1beta1.

@WIZARD-CXY I have free time, so let me fix these.

ok

May the force be with you

On Dec 10, 2015, at 4:56 PM, Flying Tiger notifications@github.com wrote:

@WIZARD-CXY I have free time, so let me fix these.

—
Reply to this email directly or view it on GitHub.