Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst" #18057

Merged
merged 1 commit into from
Dec 2, 2015

Conversation

fabioy
Copy link
Contributor

@fabioy fabioy commented Dec 2, 2015

Reverts #15645

I think this is the culprit for issue #18056. I'll manually merge on LGTM.

@fabioy
Copy link
Contributor Author

fabioy commented Dec 2, 2015

CC @ArtfulCoder, @thockin

@ArtfulCoder
Copy link
Contributor

It might have uncovered a real test configuration issue.

Sent from my iPhone

On Dec 1, 2015, at 9:02 PM, Fabio Yeon notifications@github.com wrote:

CC @ArtfulCoder, @thockin


Reply to this email directly or view it on GitHub.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2015
@fabioy
Copy link
Contributor Author

fabioy commented Dec 2, 2015

It's possible. But I'm unfamiliar with the test involved (pod seems to run some sort of script). Merge bot is stopped due to this test failing. Would you prefer we wait until test owners (in Poland?) have a chance to debug?

@fabioy fabioy assigned ArtfulCoder and unassigned smarterclayton Dec 2, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 2, 2015

GCE e2e test build/test passed for commit 7100d27.

@wojtek-t
Copy link
Member

wojtek-t commented Dec 2, 2015

Since we have blocked mergebot now, I think we can merge it asap.

@wojtek-t
Copy link
Member

wojtek-t commented Dec 2, 2015

LGTM

@gmarek

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2015
@gmarek
Copy link
Contributor

gmarek commented Dec 2, 2015

Merging to unblock the bot.

gmarek pushed a commit that referenced this pull request Dec 2, 2015
Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst"
@gmarek gmarek merged commit 11c878e into master Dec 2, 2015
@wojtek-t
Copy link
Member

wojtek-t commented Dec 2, 2015

@thockin @ArtfulCoder @gmarek

Just to give more clear context why we decided to revert it.

it broke kubemark-gce, which is currently a blocking build for mergebot
A bit more context.

in kubemark, there is no skydns (we want to add it at some point, but that's not done yet)
however, with this PR merge, this caused that no pods were started (all the pods were successfully created & scheduled, but not even a single pod was started)
note, that we are using "pause" images, which aren't the most demanding ones :)

So I think the question is the following:
if this change requires DNS to start any pod, it has be clearly stated (I'm not saying it's not reasonable - it makes sense to say that).
However, if it wasn't the intention of this PR, then there was some bug in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants