-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst" #18057
Conversation
CC @ArtfulCoder, @thockin |
It might have uncovered a real test configuration issue. Sent from my iPhone
|
Labelling this PR as size/S |
It's possible. But I'm unfamiliar with the test involved (pod seems to run some sort of script). Merge bot is stopped due to this test failing. Would you prefer we wait until test owners (in Poland?) have a chance to debug? |
GCE e2e test build/test passed for commit 7100d27. |
Since we have blocked mergebot now, I think we can merge it asap. |
LGTM |
Merging to unblock the bot. |
Revert "SkyDNS is the only NS for Pods with DNSPolicy=ClusterFirst"
Just to give more clear context why we decided to revert it. it broke kubemark-gce, which is currently a blocking build for mergebot in kubemark, there is no skydns (we want to add it at some point, but that's not done yet) So I think the question is the following: |
Reverts #15645
I think this is the culprit for issue #18056. I'll manually merge on LGTM.