update requestScope to fully qualify kind and resource #17956
Conversation
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e test build/test passed for commit 86cb9ffa2c4990524a4e8574be25570ab6b6a35c. |
| getSubpathKey string | ||
| getOptions runtime.Object | ||
| versionedGetOptions runtime.Object | ||
| getOptionsInternalFQKind unversioned.GroupVersionKind |
There was a problem hiding this comment.
What is FQ? Could we expand the acronym?
There was a problem hiding this comment.
What is FQ? Could we expand the acronym?
FullyQualified. It gets a bit long. @derekwaynecarr preferred not having GVK
|
Several questions and nits, otherwise LGTM. Thanks. |
deads2k
force-pushed
the
gv-requestscope
branch
2 times, most recently
from
2c6ecbe to
b4ca233
Compare
|
variable names changed, spelling corrected, and questioned answered. |
|
GCE e2e test build/test passed for commit b4ca23332ddf6f7282c631521854e5c14828cb48. |
|
GCE e2e test build/test passed for commit 2c6ecbe8e1dcd7f96db6f642e56671d523c18d84. |
| } | ||
|
|
||
| if err := scope.Codec.DecodeParametersInto(query, versioned); err != nil { | ||
| return nil, errors.NewBadRequest(err.Error()) | ||
| } | ||
| out, err := scope.Convertor.ConvertToVersion(versioned, internalGVString) | ||
| out, err := scope.Convertor.ConvertToVersion(versioned, internalKind.GroupVersion().String()) |
There was a problem hiding this comment.
Why do we need the internalKind, why can't we do it the old way, using scope.InternalVersion?
There was a problem hiding this comment.
Why do we need the internalKind, why can't we do it the old way, using scope.InternalVersion?
scope.InternalVersion is the internal version of the object you're returning. This method needs to have the internal version of your getOptions. The two are always different except for the legacy kube group.
deads2k
force-pushed
the
gv-requestscope
branch
from
b4ca233 to
a7dd09e
Compare
|
Thank you @deads2k. LGTM. |
caesarxuchao
added
the
lgtm
|
Continuous integration appears to have missed, closing and re-opening to trigger it |
|
GCE e2e test build/test passed for commit a7dd09e. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit a7dd09e. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Updates the
RequestScopeto have fully qualified kinds and resources.ref #17216
@liggitt @caesarxuchao
@wojtek-t I think you were in this area recently.