Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add kubectl push command #17771

Closed
wants to merge 1 commit into from
Closed

WIP: add kubectl push command #17771

wants to merge 1 commit into from

Conversation

ddysher
Copy link
Contributor

@ddysher ddysher commented Nov 25, 2015

Add a command to make pushing image to cluster registry eaiser. Some unanswered questions at #17707

$ kubectl push mongo:3.0.5
I1124 11:28:04.004007   30211 portforward.go:213] Forwarding from 127.0.0.1:5000 -> 5000
I1124 11:28:04.004073   30211 portforward.go:213] Forwarding from [::1]:5000 -> 5000
I1124 11:28:06.842722   30211 push.go:177] Push image localhost:5000/mongo:3.0.5
The push refers to a repository [localhost:5000/mongo] (len: 1)
c6f67f622b2a: Pushed 
b42e035fdac8: Pushed 
9f673fbd6c0b: Pushed 
6da089a621ff: Pushed 
78b590e9add0: Pushed 
71935c220489: Pushed 
403a86009909: Pushed 
0e1f126ca2a3: Pushed 
675abd82e9c0: Pushed 
9eddd1a555fc: Pushed 
4c8cbfd2973e: Pushed 
3.0.5: digest: sha256:b649014b244154196633b7a74f11c6032978b619fb53896013f24743ee5f0b79 size: 27916
I1124 11:30:41.673547   30211 push.go:183] Image pushed, use "localhost:5000/mongo:3.0.5" in Pod.Container.Image to access the image

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

ddysher
ddysher reviewed Nov 25, 2015
View reviewed changes
pkg/client/unversioned/portforward/portforward.go
@@ -244,8 +244,6 @@ func (pf *PortForwarder) nextRequestID() int {
func (pf *PortForwarder) handleConnection(conn net.Conn, port ForwardedPort) {
defer conn.Close()

glog.Infof("Handling connection for %d", port.Local)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to remove this to make output happy, any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddysher #17030 might help with this, possibly

@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit 7c4b07c.

@derekwaynecarr
Copy link
Member

I am curious why docker push does not work?

I am pretty sure in OpenShift we allow multiple registries, do you foresee ever doing the same on base Kubernetes?

@smarterclayton @ncdc - thoughts on this command?

@ddysher
Copy link
Contributor Author

ddysher commented Nov 27, 2015

@derekwaynecarr docker push surely works, it's just that it won't work out of the box. I do think pushing to multiple registries is a possible scenario; the command takes an optional registry name to push to.

@smarterclayton
Copy link
Contributor

I'm a bit skeptical that we're ready for something this opinionated in the cli without a larger discussion about the registry addon and extension CLIs. I also don't think this has to be a kubectl command - it can very easily be something in contrib/. It assumes details of the registry addon that I don't think represent the standard needs of a registry deployed with Kube (like security).

@ddysher
Copy link
Contributor Author

ddysher commented Nov 27, 2015

Agreed. That's why I didn't try to fully implement this. What's the plan for 'larger discussion' for such extension CLIs?

@ddysher ddysher closed this Mar 13, 2016
@ddysher ddysher deleted the kubectl-push branch March 13, 2016 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
area/kubectl size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ddysher @k8s-github-robot @k8s-bot @derekwaynecarr @smarterclayton @ncdc @k8s-teamcity-mesosphere @mikedanese @googlebot @brendandburns