Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default when latest not claimed #17278

Merged
merged 2 commits into from
Dec 6, 2015
Merged

Add default when latest not claimed #17278

merged 2 commits into from
Dec 6, 2015

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Nov 14, 2015

Fixes: #8841
Part of: #15634

Details:

  1. When user does not provide tag, they always assumed it to be latest.
  2. rkt & docker shows inconsistency in this case

@k8s-bot
Copy link

k8s-bot commented Nov 14, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 14, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2015
@erictune erictune assigned dchen1107 and unassigned erictune Nov 15, 2015
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2015
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2015
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2015
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2015
@pmorie
Copy link
Member

pmorie commented Nov 27, 2015

@k8s-bot ok to test

@pmorie
Copy link
Member

pmorie commented Nov 27, 2015

@k8s-bot add to whitelist

@k8s-bot
Copy link

k8s-bot commented Nov 27, 2015

GCE e2e build/test failed for commit 707e0edc98e468b7a17e8e229e6c8615c5ef71e7.

@k8s-bot
Copy link

k8s-bot commented Nov 27, 2015

GCE e2e build/test failed for commit 707e0edc98e468b7a17e8e229e6c8615c5ef71e7.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 91184a815c0d7bdb8c8af2da4ee412b1961c33a1.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@pmorie
Copy link
Member

pmorie commented Dec 2, 2015

@yifan-gu This doesn't seem like it's going to play nice with rkt images, which are just URLs IIRC. Thoughts?

@yifan-gu
Copy link
Contributor

yifan-gu commented Dec 2, 2015

@pmorie Thanks for the heading up :)
rkt is only using the docker images now, so it doesn't matter. For rkt images(ACI), it supports pure http/https URL, such as http://example.com/foo.aci, as well as the discovery URL, such as example.com/foo. For the later, if there is no tags, then it assumes latest as well. so example.com/foo = example.com/foo:latest.

BTW, I am working on a proposal for adding more support for other image format here

cc @jonboulle

@yujuhong
Copy link
Contributor

yujuhong commented Dec 2, 2015

LGTM. Thanks for fixing this! The default should be part of the api (i.e., image spec) if we change the api in the future. Given that we don't have that, the current approach seems fine.

@yujuhong yujuhong assigned yujuhong and unassigned dchen1107 Dec 2, 2015
@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2015
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Dec 3, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 4, 2015

GCE e2e build/test failed for commit 5552d70.

@resouer resouer closed this Dec 4, 2015
@resouer resouer reopened this Dec 4, 2015
@resouer
Copy link
Contributor Author

resouer commented Dec 4, 2015

May be need to re-run e2e

@yujuhong
Copy link
Contributor

yujuhong commented Dec 4, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Dec 4, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e build/test failed for commit 5552d70.

@gmarek
Copy link
Contributor

gmarek commented Dec 6, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Dec 6, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 6, 2015

GCE e2e test build/test passed for commit 5552d70.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 6, 2015
Merge pull request #17278 from ZJU-SEL/fix-nil-tag
810181f 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 810181f into kubernetes:master Dec 6, 2015
thockin pushed a commit to thockin/kubernetes that referenced this pull request Dec 7, 2015
@thockin
Merge pull request kubernetes#17278 from ZJU-SEL/fix-nil-tag
d010e55 
Auto commit by PR queue bot
@gavinfish gavinfish mentioned this pull request Apr 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.